Changeset 12269

Timestamp:

11/23/2022 04:16:19 AM (4 years ago)

Author:

dd32

Message:

Make: Trac Props editor: Restrict props editing to those who can publish posts.

Props peterwilsoncc, dd32.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-trac-watcher/admin

Files:

• list-table.php (modified) (3 diffs)
• post.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-trac-watcher/admin/list-table.php

@@ -342 +342 @@
 
                         case 'props':
-                                $output = '<div class="propslist">';
+                                $can_edit = current_user_can( 'publish_posts' );
+                                $output   = '<div class="propslist">';
 
                                 foreach ( $item->props as $prop => $user_id ) {
@@ -373 +374 @@
                                                 $output .= '</a>';
                                         }
-                                        $output .= '<div class="overlay"><div class="actions"><a href="#" class="edit dashicons dashicons-edit"></a></div></div>';
+                                        if ( $can_edit ) {
+                                                $output .= '<div class="overlay"><div class="actions"><a href="#" class="edit dashicons dashicons-edit"></a></div></div>';
+                                        }
 
                                         if ( $prop_is_different_from_user || $prop_display_name_different ) {
@@ -385 +388 @@
                                         $output .= '</span>';
                                 }
-                                $output .= '<span class="user add"><a href="#" class="add dashicons dashicons-plus"></a>&nbsp;<a href="#" class="add">Add new</a></span>';
+
+                                if ( $can_edit ) {
+                                        $output .= '<span class="user add"><a href="#" class="add dashicons dashicons-plus"></a>&nbsp;<a href="#" class="add">Add new</a></span>';
+                                }
+
                                 $output .= '</div>';
 
-                                $output .= '<p class="actions"><a href="#" class="reparse">Reparse</a></p>';
+                                if ( $can_edit ) {
+                                        $output .= '<p class="actions"><a href="#" class="reparse">Reparse</a></p>';
+                                }
 
                                 return $output;

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-trac-watcher/admin/post.php

@@ -5 +5 @@
         global $wpdb;
 
-        if ( ! current_user_can( 'edit_posts' ) ) {
+        if ( ! current_user_can( 'publish_posts' ) ) {
                 die( '-1' );
         }
@@ -133 +133 @@
         global $wpdb;
 
-        if ( ! current_user_can( 'edit_posts' ) ) {
+        if ( ! current_user_can( 'publish_posts' ) ) {
                 die( '-1' );
         }