Changeset 12324

Timestamp:

12/14/2022 02:16:09 AM (3 years ago)

Author:

dd32

Message:

Plugin Directory: Restore the Locale banner on the plugin directory front page.

The validation rejects an empty plugin_slug, so the API was throwing an error instead of a language suggest.

Location:

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins

Files:

• functions.php (modified) (1 diff)
• js/locale-banner.js (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/functions.php

@@ -91 +91 @@
 
     if ( ! is_404() ) {
-        wp_enqueue_script( 'wporg-plugins-locale-banner', get_stylesheet_directory_uri() . '/js/locale-banner.js', array( 'jquery' ), '20200401', true );
+        wp_enqueue_script( 'wporg-plugins-locale-banner', get_stylesheet_directory_uri() . '/js/locale-banner.js', array( 'jquery' ), filemtime( __DIR__ . '/js/locale-banner.js' ), true );
         wp_localize_script( 'wporg-plugins-locale-banner', 'wporgLocaleBanner', array(
             'apiURL'        => rest_url( '/plugins/v1/locale-banner' ),

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/js/locale-banner.js

@@ -10 +10 @@
         url: wporgLocaleBanner.apiURL,
         dataType: 'json',
-        data: {
-            'plugin_slug': wporgLocaleBanner.currentPlugin
-        },
+        data: wporgLocaleBanner.currentPlugin ? { 'plugin_slug': wporgLocaleBanner.currentPlugin } : {},
         success: function ( response ) {
             if ( ! response.suggest_string ) {