Changeset 12347

Timestamp:

12/20/2022 02:36:14 AM (22 months ago)

Author:

dd32

Message:

Support Forums: Plugin/Theme/Review "forums": Make bbp_get_forum_id() work in the plugin/theme/review "forums".

These forums are not forums, but rather, are views of a forum. As a result of this, bbPress doesn't return a forum object even through it's seen as a single forum.

This caused the Block Editor to be enabled for these views due to a misconfiguration of the Blocks integration, where in the event it couldn't find a forum for the current page, defaulted to being enabled.

This code aims to remove similar faults in the future, by allowing bbp_get_forum_id() to return the true forum_id for these forums, while at the same time being a view.

This should not be removed without verifying that [12348] works as expected.

See #6608.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-directory-compat.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-directory-compat.php

@@ -63 +63 @@
             // Tell WordPress not to 404 (before bbPress overrides it) so that Canonical can do it's job.
             add_filter( 'pre_handle_404', array( $this, 'abort_wp_handle_404' ) );
+
+            // Let plugins know which forum we're in.
+            add_filter( 'bbp_get_forum_id', array( $this, 'bbp_get_forum_id' ) );
+
         }
     }
@@ -727 +731 @@
     }
 
+    /**
+     * These compat routes are views, but showing a singular forum.
+     * This makes other plugins understand that the compat view is a forum.
+     *
+     * @param int $forum_id The detected forum id.
+     * @return int The actual forum id.
+     */
+    public function bbp_get_forum_id( $forum_id ) {
+        if ( ! $forum_id && bbp_is_single_view() ) {
+            if ( $this->compat() === bbp_get_view_id() ) {
+                $forum_id = $this->forum_id();
+            } elseif ( 'reviews' == bbp_get_view_id() ) {
+                $forum_id = Plugin::REVIEWS_FORUM_ID;
+            }
+        }
+
+        return $forum_id;
+    }
 
     /**