Changeset 12393

Timestamp:

02/13/2023 05:40:44 PM (8 months ago)

Author:

Clorith

Message:

Support Forums: Always require a reason for topic reports.

When reporting a topic, users have had the option to choose from a set of pre-determined reasons, or if none of the reasons were applicable, choosing the "other" alternative would give them a freeform text-field.

Using a pre-determined reason may leave reports short on context, where it could be down to the reporters interpretation why a reason was chosen, and would not be clear to those looking over reports.
This change addresses that by always requiring a user to not just choose a reason, but also provide context via the field asking "Why are you reporting this topic" when using the report tool in the sidebar.

Fixes #5706.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-report-topic.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-report-topic.php

@@ -106 +106 @@
             wp_add_object_terms( $_POST['wporg-support-report-topic'], 'modlook', 'topic-tag' );
 
-            $reason = $_POST['topic-report-reason'];
-
-            if ( 'other-input' === $reason ) {
-                $reason = $_POST['topic-report-reason-other'];
-            }
+            $reason = sprintf(
+                '%s: %s',
+                $_POST['topic-report-reason'],
+                $_POST['topic-report-reason-details']
+            );
 
             $this->add_modlook_history( $_POST['wporg-support-report-topic'], $reason );
@@ -173 +173 @@
 
                 <label for="topic-report-reason"><?php _e( 'Report this topic for:', 'wporg-forums' ); ?></label>
-                <select name="topic-report-reason" id="topic-report-reason" required="required" onchange="wporg_report_topic_change()">
+                <select name="topic-report-reason" id="topic-report-reason" required="required">
                     <option value=""><?php _ex( '&mdash; Choose one &mdash;', 'Report a topic reason', 'wporg-forums' ); ?></option>
                     <option><?php _ex( 'Guideline violation', 'Report a topic reason', 'wporg-forums' ); ?></option>
@@ -181 +181 @@
                     <option value="other-input"><?php _ex( 'Other', 'Report a topic reason', 'wporg-forums' ); ?></option>
                 </select>
-                <aside id="report-topic-other" style="display: none;">
-                    <label for="topic-report-reason-other"><?php _e( 'Your own reason:', 'wporg-forums' ); ?></label>
-                    <input type="text" name="topic-report-reason-other" id="topic-report-reason-other">
+                <aside id="report-topic-other">
+                    <label for="topic-report-reason-details"><?php _e( 'Why are you reporting this topic:', 'wporg-forums' ); ?></label>
+                    <input type="text" name="topic-report-reason-details" id="topic-report-reason-details" required="required">
                 </aside>
                 <input type="submit" name="submit" value="<?php esc_attr_e( 'Report', 'wporg-forums' ); ?>">
             </form>
-
-            <script type="text/javascript">
-                function wporg_report_topic_change() {
-                    if ( 'other-input' === document.getElementById('topic-report-reason').value ) {
-                        document.getElementById( 'report-topic-other' ).style.display = 'block';
-                    } else {
-                        document.getElementById( 'report-topic-other' ).style.display = 'none';
-                    }
-                }
-            </script>
 <?php
             $report_text = ob_get_clean();