Changeset 12396

Timestamp:

02/13/2023 11:31:27 PM (3 years ago)

Author:

iandunn

Message:

Props: Find Slack user IDs in bulleted lists

See ​https://wordpress.slack.com/archives/C02QB8GMM/p1676068080079459

Location:

sites/trunk/common/includes/slack/props

Files:

• lib.php (modified) (4 diffs)
• readme.md (added)
• tests/mentions-in-list.json (added)
• tests/test-lib.php (modified) (2 diffs)

sites/trunk/common/includes/slack/props/lib.php

@@ -8 +8 @@
  * Adds props in Slack to w.org profiles.
  *
- * Receives webhook notifications for all new messages in `#props`,
+ * Receives webhook notifications for all new messages in `#props`. See `dotorg/slack/props.php` for the caller.
  */
 function handle_props_message( object $request ) : string {
@@ -87 +87 @@
 /**
  * Parse the mentioned Slack user IDs from a message event.
- *
- * This assumes that the app is configured to escape usernames.
  */
 function get_recipient_slack_ids( array $blocks ) : array {
@@ -95 +93 @@
     foreach ( $blocks as $block ) {
         foreach ( $block->elements as $element ) {
-            foreach ( $element->elements as $inner_element ) {
-                if ( 'user' !== $inner_element->type ) {
-                    continue;
-                }
-
-                $ids[] = $inner_element->user_id;
-            }
+            $ids = array_merge( $ids, get_user_ids_from_element( $element ) );
         }
     }
@@ -107 +99 @@
     return array_unique( $ids );
 }
+
+/**
+ * Recursively parse any mentioned Slack user IDs from a message element.
+ *
+ * This assumes that the app is configured to escape usernames.
+ */
+function get_user_ids_from_element( object $element ) : array {
+    $ids = array();
+
+    if ( 'user' === $element->type ) {
+        $ids[] = $element->user_id;
+    }
+
+    if ( isset( $element->elements ) ) {
+        foreach ( $element->elements as $inner_element ) {
+            $ids = array_merge( $ids, get_user_ids_from_element( $inner_element ) );
+        }
+    }
+
+    return $ids;
+}
+
 
 /**

sites/trunk/common/includes/slack/props/tests/test-lib.php

@@ -125 +125 @@
         );
 
+        $mentions_in_list = json_decode( file_get_contents( __DIR__ . '/mentions-in-list.json' ) );
+
         $cases = array(
             'empty' => array(
@@ -133 +135 @@
             'user mentioned twice' => array(
                 'blocks'   => $mentioned_twice,
+                'expected' => $valid_users,
+            ),
+
+            'mentions in a list' => array(
+                'blocks'   => $mentions_in_list,
                 'expected' => $valid_users,
             ),