Changeset 12408

Timestamp:

02/20/2023 06:24:22 PM (3 years ago)

Author:

amieiro

Message:

Translate: Update the events and selector to load the tabs in the right sidebar with different events

Currently, the tab content was only loaded when a user double click on the row.
With this udpate, the info is loaded with double click, clicking in the "Details"
button and with the hotkeys, because the loading is fired when the translation
textarea gets the focus.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/gp-translation-helpers/js/editor.js (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/gp-translation-helpers/js/editor.js

@@ -12 +12 @@
     } );
 
-    // When a new translation row is opened (with double click), the tabs
-    // (header tab and content) for this row are updated with the Ajax query.
-    $gp.editor.table.on( 'dblclick', 'tr.preview td', function() {
-        loadTabsAndDivs( $( this ) );
-    } );
-
-    // When a new translation row is opened (clicking in the "Details" button), the
-    // tabs (header tab and content) for this row are updated with the Ajax query.
-    $gp.editor.table.on( 'click', '.action.edit', function( ) {
-        loadTabsAndDivs( $( this ) );
+    // When a new translation row is opened (with double click, clicking in the "Details" button,
+    // or with the hotkeys), the translation textarea is focused, so the tabs (header tabs and
+    // divs with the content) for the right sidebar are updated.
+    $gp.editor.table.on( 'focus input', 'tr.editor textarea.foreign-text', function() {
+        var tr = $( this ).closest( 'tr.editor' );
+        loadTabsAndDivs( tr );
     } );
 
@@ -203 +199 @@
      */
     function loadTabsAndDivs( element ) {
-        var originalId = element.closest( 'tr' ).attr( 'id' ).substring( 8 );
+        var originalId = element.closest( 'tr' ).attr( 'id' ).substring( 7 );
         var requestUrl = $gp_translation_helpers_editor.translation_helper_url + originalId + '?nohc';
         $.getJSON( requestUrl, function( data ) {