Changeset 12424

Timestamp:

02/27/2023 01:54:42 AM (4 years ago)

Author:

dd32

Message:

Translate: Fix constant PHP Notices.

See ​https://github.com/GlotPress/gp-translation-helpers/pull/162

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/gp-translation-helpers

Files:

• helpers/helper-translation-discussion.php (modified) (1 diff)
• includes/class-wporg-notifications.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/gp-translation-helpers/helpers/helper-translation-discussion.php

@@ -580 +580 @@
                                 'translation_id'       => isset( $this->data['translation_id'] ) ? $this->data['translation_id'] : null,
                                 'locale_slug'          => $this->data['locale_slug'],
-                                'original_permalink'   => $this->data['original_permalink'],
+                                'original_permalink'   => $this->data['original_permalink'] ?? false,
                                 'original_id'          => $this->data['original_id'],
                                 'project'              => $this->data['project'],

sites/trunk/wordpress.org/public_html/wp-content/plugins/gp-translation-helpers/includes/class-wporg-notifications.php

@@ -148 +148 @@
                                                         }
 
-                                                                $user = get_user_by( 'email', $email );
+                                                        $user = get_user_by( 'email', $email );
+                                                        if ( $user ) {
                                                                 return array(
                                                                         'ID'            => $user->ID,
@@ -157 +158 @@
                                                                         'image_URL'     => get_avatar_url( $user->ID ),
                                                                 );
+                                                        }
+
+                                                        return false;
                                                 },
                                                 $all_email_addresses
                                         );
-                                                        return $users;
+
+                                        $users = array_filter( $users );
+
+                                        return $users;
                                 },
                                 10,