Changeset 12434 for sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-customizations/inc/cli/class-stats.php

Timestamp:

02/28/2023 08:54:26 PM (2 years ago)

Author:

akirk

Message:

Polyglots Stats: Improve memory usage by optimizing SQL statements

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-customizations/inc/cli/class-stats.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-customizations/inc/cli/class-stats.php

@@ -948 +948 @@
             ),
         );
-
-        $feedback_posts                 = new WP_Query( $feedback_posts_args );
-        $original_strings_with_comments = number_format_i18n( $feedback_posts->post_count );
+        $feedback_posts_count = $wpdb->get_var( $wpdb->prepare(
+            "SELECT COUNT(*) FROM $wpdb->posts WHERE post_status='publish' AND post_type=%s AND post_date > %s", $this::FEEDBACK_POST_TYPE, '2022-07-28'
+        ));
+        $original_strings_with_comments = number_format_i18n( $feedback_posts_count );
 
         // Get the total number of comments.
@@ -969 +970 @@
         // First, get the comments related with a translation, because we can get comments related
         // only with the original.
-        $comments = get_comments(
-            array(
-                'post_type'  => $this::FEEDBACK_POST_TYPE,
-                'count'      => false,
-                'meta_key'   => 'translation_id',
-                'date_query' => array(
-                    array( 'after' => '2022-07-28' ),
-                ),
-            )
-        );
-
-        // Get the translation ids with a feedback comment.
-        foreach ( $comments as $comment ) {
-            $comment_meta_translation_ids[] = get_comment_meta( $comment->comment_post_ID, 'translation_id', true );
-        }
-        $comment_meta_translation_ids = array_unique( $comment_meta_translation_ids );
+        $comment_meta_translation_ids = $wpdb->get_col( $wpdb->prepare(
+            "SELECT cm.meta_value FROM $wpdb->commentmeta cm, $wpdb->comments c, $wpdb->posts p WHERE p.post_status='publish' AND p.post_type=%s AND p.post_date > %s AND cm.meta_key = 'translation_id' AND c.comment_post_id = p.id AND cm.comment_id = c.comment_id", $this::FEEDBACK_POST_TYPE, '2022-07-28'
+        ));
 
         // Check all comments with a related translation.
@@ -1028 +1016 @@
 
         // Get most active commenter's.
-        $comments = get_comments(
-            array(
-                'post_type'  => $this::FEEDBACK_POST_TYPE,
-                'count'      => false,
-                'date_query' => array(
-                    array( 'after' => '2022-07-28' ),
-                ),
-            )
-        );
-        foreach ( $comments as $comment ) {
-            $comment_user_ids[] = $comment->user_id;
-        }
+        $comment_user_ids = $wpdb->get_col( $wpdb->prepare(
+            "SELECT c.user_id FROM $wpdb->comments c, $wpdb->posts p WHERE p.post_status='publish' AND p.post_type=%s AND p.post_date > %s AND c.comment_post_id = p.id", $this::FEEDBACK_POST_TYPE, '2022-07-28'
+        ));
 
         $commenters_with_comment_count = array_count_values( $comment_user_ids );