Changeset 12517

Timestamp:

03/30/2023 03:37:47 AM (2 years ago)

Author:

dd32

Message:

Plugin Directory: Administration: Add bulk actions for close/disable/open.

This streamlines administration of cases where a large group of plugins need to be disabled or re-opened.

Fixes #6903.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin

Files:

• class-customizations.php (modified) (3 diffs)
• class-status-transitions.php (modified) (2 diffs)
• list-table/class-plugin-posts.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/class-customizations.php

@@ -31 +31 @@
         add_action( 'pre_get_posts', array( $this, 'pre_get_posts' ) );
 
-        add_action( 'load-edit.php', array( $this, 'bulk_reject_plugins' ) );
+        add_action( 'load-edit.php', array( $this, 'bulk_action_plugins' ) );
         add_action( 'admin_enqueue_scripts', array( $this, 'enqueue_assets' ) );
         add_filter( 'admin_head-edit.php', array( $this, 'plugin_posts_list_table' ) );
@@ -229 +229 @@
 
     /**
-     * Rejects plugins in bulk.
-     */
-    public function bulk_reject_plugins() {
-        if ( empty( $_REQUEST['action'] ) || empty( $_REQUEST['action2'] ) || ! in_array( 'plugin_reject', array( $_REQUEST['action'], $_REQUEST['action2'] ) ) || 'plugin' !== $_REQUEST['post_type'] ) {
+     * Performs plugin status changes in bulk.
+     */
+    public function bulk_action_plugins() {
+        if (
+            empty( $_REQUEST['action'] ) ||
+            empty( $_REQUEST['action2'] ) ||
+            'plugin' !== $_REQUEST['post_type']
+        ) {
             return;
         }
@@ -238 +242 @@
         check_admin_referer( 'bulk-posts' );
 
-        $rejected = 0;
+        $action = array_intersect(
+            [ 'plugin_open', 'plugin_close', 'plugin_disable', 'plugin_reject' ],
+            [ $_REQUEST['action'], $_REQUEST['action2'] ]
+        );
+        $action = array_shift( $action );
+        if ( ! $action ) {
+            return;
+        }
+
+        switch( $action ) {
+            case 'plugin_open':
+                $capability = 'plugin_approve';
+                $new_status = 'publish';
+                $message    = _n_noop( '%s plugin opened.', '%s plugins opened.', 'wporg-plugins' );
+                $from_state = [ 'closed', 'disabled' ];
+                break;
+            case 'plugin_close':
+                $capability = 'plugin_close';
+                $new_status = 'closed';
+                $message    = _n_noop( '%s plugin closed.', '%s plugins closed.', 'wporg-plugins' );
+                $from_state = [ 'closed', 'disabled', 'publish', 'approved' ];
+                break;
+            case 'plugin_disable':
+                $capability = 'plugin_close';
+                $new_status = 'disabled';
+                $message    = _n_noop( '%s plugin disabled.', '%s plugins disabled.', 'wporg-plugins' );
+                $from_state = [ 'closed', 'disabled', 'publish', 'approved' ];
+                break;
+            case 'plugin_reject':
+                $capability = 'plugin_reject';
+                $new_status = 'rejected';
+                $message    = _n_noop( '%s plugin rejected.', '%s plugins rejected.', 'wporg-plugins' );
+                $from_state = [ 'new', 'pending' ];
+                break;
+            default:
+                return;
+        }
+
+        $closed = 0;
         $plugins  = get_posts( array(
             'post_type'      => 'plugin',
             'post__in'       => array_map( 'absint', $_REQUEST['post'] ),
-            'post_status'    => array( 'new', 'pending' ),
+            'post_status'    => $from_state,
             'posts_per_page' => count( $_REQUEST['post'] ),
         ) );
 
         foreach ( $plugins as $plugin ) {
-            if ( ! current_user_can( 'plugin_reject', $plugin ) ) {
-                wp_die( __( 'You are not allowed to reject this plugin.', 'wporg-plugins' ), '', array( 'back_link' => true ) );
+            if ( ! current_user_can( $capability, $plugin ) ) {
+                continue;
             }
 
             $updated = wp_update_post( array(
                 'ID'          => $plugin->ID,
-                'post_status' => 'rejected',
+                'post_status' => $new_status,
             ) );
 
             if ( $updated && ! is_wp_error( $updated ) ) {
-                $rejected++;
-            }
-        }
-
-        if ( $rejected ) {
-            set_transient( 'settings_errors', array(
-                array(
-                    'setting' => 'wporg-plugins',
-                    'code'    => 'plugins-bulk-rejected',
-                    'message' => sprintf( _n( '%d plugin rejected.', '%d plugins rejected.', $rejected, 'wporg-plugins' ), $rejected ),
-                    'type'    => 'updated',
-                ),
-            ) );
-        }
+                $closed++;
+            }
+
+        }
+
+        set_transient( 'settings_errors', array(
+            array(
+                'setting' => 'wporg-plugins',
+                'code'    => 'plugins-bulk-actioned',
+                'message' => sprintf( translate_nooped_plural( $message, $closed, 'wporg-plugins' ), number_format_i18n( $closed ) ),
+                'type'    => 'updated',
+            ),
+        ) );
 
         $send_back = remove_query_arg( array( 'trashed', 'untrashed', 'deleted', 'locked', 'ids', 'action', 'action2', 'tags_input', 'post_author', 'comment_status', 'ping_status', '_status', 'post', 'bulk_edit', 'post_view' ), wp_get_referer() );
-        wp_redirect( add_query_arg( array( 'settings-updated' => true ), $send_back ) );
+        wp_safe_redirect( add_query_arg( array( 'settings-updated' => true ), $send_back ) );
         exit;
     }

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/class-status-transitions.php

@@ -323 +323 @@
      */
     public function save_close_reason( $post_id ) {
-        if ( ! isset( $_POST['close_reason'] ) ) {
+        if ( ! isset( $_REQUEST['close_reason'] ) ) {
             return;
         }
@@ -331 +331 @@
         }
 
-        $close_reason = sanitize_key( $_POST['close_reason'] );
+        $close_reason = sanitize_key( $_REQUEST['close_reason'] );
 
         update_post_meta( $post_id, '_close_reason', $close_reason );

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/list-table/class-plugin-posts.php

@@ -81 +81 @@
         if ( current_user_can( 'plugin_reject' ) && ( empty( $_REQUEST['post_status'] ) || in_array( $_REQUEST['post_status'], array( 'new', 'pending' ) ) ) ) {
             $actions['plugin_reject'] = __( 'Reject', 'wporg-plugins' );
+        }
+
+        if ( current_user_can( 'plugin_approve' ) && ( empty( $_REQUEST['post_status'] ) || in_array( $_REQUEST['post_status'], array( 'closed', 'disabled' ) ) ) ) {
+            $actions['plugin_open'] = __( 'Open', 'wporg-plugins' );
+        }
+
+        if ( current_user_can( 'plugin_close' ) && ( empty( $_REQUEST['post_status'] ) || in_array( $_REQUEST['post_status'], array( 'publish', 'approved', 'disabled' ) ) ) ) {
+            $actions['plugin_close'] = __( 'Close', 'wporg-plugins' );
+        }
+
+        if ( current_user_can( 'plugin_close' ) && ( empty( $_REQUEST['post_status'] ) || in_array( $_REQUEST['post_status'], array( 'publish', 'approved', 'closed' ) ) ) ) {
+            $actions['plugin_disable'] = __( 'Disable', 'wporg-plugins' );
         }
 
@@ -500 +512 @@
         return $status_links;
     }
+
+    /**
+     * Display the "actions" fields below the filters.
+     */
+    public function extra_tablenav( $which ) {
+        parent::extra_tablenav( $which );
+
+        // TODO: This shouldn't have inline CSS/JS.
+
+        if ( 'top' === $which ) {
+            ?>
+            <fieldset class="alignleft actions hide-if-js bulk-plugin_close bulk-plugin_disable" disabled="disabled">
+                <select name="close_reason" id="close_reason">
+                    <option disabled="disabled" value='' selected="selected"><?php esc_html_e( 'Close/Disable Reason:', 'wporg-plugins' ); ?></option>
+                    <?php foreach ( Template::get_close_reasons() as $key => $label ) : ?>
+                        <option value="<?php echo esc_attr( $key ); ?>"><?php echo esc_html( $label ); ?></option>
+                    <?php endforeach; ?>
+                </select>
+            </fieldset>
+            <style>
+                #posts-filter fieldset.bulk-plugin_close {
+                    margin: 0;
+                }
+            </style>
+            <script>
+            jQuery( function( $ ) {
+                $( '.bulkactions' ).on( 'change', function() {
+                    var $this = $( this ),
+                        val = $this.find(':selected').val(),
+                        $tablenav = $this.parents('form').find( '.tablenav.top' );
+
+                    $tablenav.find( '.actions.bulk-plugin_close, .actions.bulk-plugin_disable' ).prop( 'disabled', true ).hide();
+                    $tablenav.find( '.actions.bulk-' + val ).prop( 'disabled', false ).show();
+                } );
+            } );
+            </script>
+            <?php
+        }
+    }
 }