Changeset 12529

Timestamp:

04/11/2023 03:18:35 AM (3 years ago)

Author:

dd32

Message:

Support Forums: Disable RSS feeds for bbPress views that don't exist.

These views ultimately query for all posts, without any query restrictions, which ultimately causes exceesive load on the support forums.

See ​https://bbpress.trac.wordpress.org/ticket/3544.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-performance-optimizations.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-performance-optimizations.php

@@ -64 +64 @@
         // ..and don't do expensive orderbys & counting for user queries that don't need it.
         add_action( 'pre_get_users', array( $this, 'pre_get_users' ) );
+
+        // Disable feeds for non-existent views. See https://bbpress.trac.wordpress.org/ticket/3544
+        add_action( 'bbp_request', array( $this, 'bbp_request_disable_missing_view_feeds' ), 9 ); // Before bbp_request_feed_trap().
     }
 
@@ -636 +639 @@
         }
     }
+
+    /**
+     * Disable feeds for missing bbPress views.
+     *
+     * @see https://bbpress.trac.wordpress.org/ticket/3544
+     *
+     * @param array $query_vars
+     * @return array
+     */
+    public function bbp_request_disable_missing_view_feeds( $query_vars ) {
+        $view_id = bbp_get_view_rewrite_id();
+
+        if (
+            isset( $query_vars['feed'] ) &&
+            isset( $query_vars[ $view_id ] ) &&
+            ! bbp_get_view_query_args( $query_vars[ $view_id ] )
+        ) {
+            unset( $query_vars[ $view_id ] );
+
+            // Set a 404 status, without this bbPress is unsure of what to do.
+            $query_vars['error'] = 404;
+        }
+
+        return $query_vars;
+    }
 }