Changeset 12533

Timestamp:

04/12/2023 05:24:19 AM (20 months ago)

Author:

dd32

Message:

Plugin Directory: Store required plugins as an array, and an additional flag for when dependencies are not met by published WordPress.org-hosted plugins.

See #6921, [12532].

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory

Files:

• api/routes/class-plugin.php (modified) (1 diff)
• cli/class-import.php (modified) (2 diffs)
• shortcodes/class-upload-handler.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/api/routes/class-plugin.php

@@ -113 +113 @@
         }
 
-        $result['requires']      = get_post_meta( $post_id, 'requires', true ) ?: false;
-        $result['tested']        = get_post_meta( $post_id, 'tested', true ) ?: false;
-        $result['requires_php']  = get_post_meta( $post_id, 'requires_php', true ) ?: false;
-        $result['compatibility'] = array();
+        $result['requires']         = get_post_meta( $post_id, 'requires', true ) ?: false;
+        $result['tested']           = get_post_meta( $post_id, 'tested', true ) ?: false;
+        $result['requires_php']     = get_post_meta( $post_id, 'requires_php', true ) ?: false;
+        $result['requires_plugins'] = get_post_meta( $post_id, 'requires_plugins', true ) ?: [];
+        $result['compatibility']    = array();
 
         if ( class_exists( '\WPORG_Ratings' ) ) {

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-import.php

@@ -42 +42 @@
     // Plugin headers that are stored in plugin meta
     public $plugin_headers = array(
-        // Header         => meta_key
-        'Name'            => 'header_name',
-        'PluginURI'       => 'header_plugin_uri',
-        'Author'          => 'header_author',
-        'AuthorURI'       => 'header_author_uri',
-        'TextDomain'      => 'header_textdomain',
-        'RequiresPlugins' => 'requires_plugins'
+        // Header    => meta_key
+        'Name'       => 'header_name',
+        'PluginURI'  => 'header_plugin_uri',
+        'Author'     => 'header_author',
+        'AuthorURI'  => 'header_author_uri',
+        'TextDomain' => 'header_textdomain',
 
         // These headers are stored in these fields, but are handled separately.
-        // 'Version'     => 'version',
-        // 'RequiresWP'  => 'requires',
-        // 'RequiresPHP' => 'requires_php',
+        // 'Version'         => 'version',
+        // 'RequiresWP'      => 'requires',
+        // 'RequiresPHP'     => 'requires_php',
+        // 'RequiresPlugins' => 'requires_plugins'
     );
 
@@ -240 +240 @@
             $plugin_names[ $headers->Name ] = $headers->Version;
             update_post_meta( $plugin->ID, 'plugin_name_history', wp_slash( $plugin_names ) );
+        }
+
+        // Validate whether the dependencies are met by WordPress.org-hosted plugins.
+        $requires_plugins       = array_map( 'trim', explode( ',', $headers->RequiresPlugins ) );
+        $requires_plugins_unmet = false;
+        foreach ( $requires_plugins as $requires_plugin_slug ) {
+            // TODO: Add support for premium plugins.
+            $requires_plugin_post = Plugin_Directory::get_plugin_post( $requires_plugin_slug );
+            if (
+                ! $requires_plugin_post ||
+                'publish' !== $requires_plugin_post->post_status
+            ) {
+                $requires_plugins_unmet = true;
+                break;
+            }
+        }
+
+        update_post_meta( $plugin->ID, 'requires_plugins', wp_slash( $requires_plugins ) );
+        if ( $requires_plugins_unmet ) {
+            update_post_meta( $plugin->ID, '_requires_plugins_unmet', true );
+        } else {
+            delete_post_meta( $plugin->ID, '_requires_plugins_unmet' );
         }
 

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-upload-handler.php

@@ -378 +378 @@
                     'header_textdomain'        => $this->plugin['TextDomain'],
                     'header_description'       => $this->plugin['Description'],
-                    'requires_plugins'         => $this->plugin['RequiresPlugins'],
+                    'requires_plugins'         => array_map( 'trim', explode( ',', $this->plugin['RequiresPlugins'] ) ),
                     'assets_screenshots'       => array(),
                     'assets_icons'             => array(),