Changeset 12534

Timestamp:

04/12/2023 05:32:20 AM (2 years ago)

Author:

dd32

Message:

Plugin Directory: When a plugin has an empty or malformed Requires Plugins header, don't store empty slug keys.

See #6921.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory

Files:

• cli/class-import.php (modified) (1 diff)
• shortcodes/class-upload-handler.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-import.php

@@ -243 +243 @@
 
         // Validate whether the dependencies are met by WordPress.org-hosted plugins.
-        $requires_plugins       = array_map( 'trim', explode( ',', $headers->RequiresPlugins ) );
+        $requires_plugins       = array_filter( array_map( 'trim', explode( ',', $headers->RequiresPlugins ) ) );
         $requires_plugins_unmet = false;
         foreach ( $requires_plugins as $requires_plugin_slug ) {

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-upload-handler.php

@@ -378 +378 @@
                     'header_textdomain'        => $this->plugin['TextDomain'],
                     'header_description'       => $this->plugin['Description'],
-                    'requires_plugins'         => array_map( 'trim', explode( ',', $this->plugin['RequiresPlugins'] ) ),
+                    'requires_plugins'         => array_filter( array_map( 'trim', explode( ',', $this->plugin['RequiresPlugins'] ) ) ),
                     'assets_screenshots'       => array(),
                     'assets_icons'             => array(),