Changeset 12539

Timestamp:

04/13/2023 11:21:17 PM (3 years ago)

Author:

coffee2code

Message:

Photo Directory, Uploads: Reinforce intent of text input as being for alternative text.

• Rename the field from "Description" to "Alternative Text"
• Make the field required
• Increase field's input limit to 350 characters
• Display the field as a textarea
• Add help text that explicitly requests that the contents of the photo be described

Props alexstine, otto42, coffee2code.
See #6173.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/photo-directory

Files:

• assets/js/submit.js (modified) (1 diff)
• inc/uploads.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/photo-directory/assets/js/submit.js

@@ -112 +112 @@
  */
 function photoGetInputFields( form ) {
-        return form.querySelectorAll( 'input:not([type="hidden"]):not([type="submit"]):not([type="button"]):not([type="file"])');
+        return form.querySelectorAll('textarea, input:not([type="hidden"]):not([type="submit"]):not([type="button"]):not([type="file"])');
 }
 

sites/trunk/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/uploads.php

@@ -15 +15 @@
          * @var int
          */
-        const MAX_LENGTH_DESCRIPTION = 250;
+        const MAX_LENGTH_DESCRIPTION = 350;
 
         /**
@@ -909 +909 @@
                                 . "</div>\n"
                                 . sprintf(
-                                        '[%s name="post_content" class="textarea" id="ug_content" description="%s" maxlength="%d" help="%s"]' . "\n",
+                                        '[%s name="post_content" class="textarea" id="ug_content" description="%s" required="required" aria-required="true" maxlength="%d" help="%s"]' . "\n",
                                         $description_shortcode,
-                                        esc_attr( __( 'Description (optional)', 'wporg-photos' ) ),
+                                        esc_attr( __( 'Alternative Text (required)', 'wporg-photos' ) ),
                                         self::MAX_LENGTH_DESCRIPTION,
-                                        esc_attr( sprintf( __( 'Maximum of %d characters. No HTML.', 'wporg-photos' ), self::MAX_LENGTH_DESCRIPTION ) )
+                                        esc_attr( sprintf( __( 'Describe what can be seen in the photo for the benefit of those without sight. May be edited by moderators. Maximum of %d characters. No HTML.', 'wporg-photos' ), self::MAX_LENGTH_DESCRIPTION ) )
                                 )
                                 . '<div class="upload-checkbox-wrapper">' . "\n";