Changeset 12555

Timestamp:

04/24/2023 01:29:15 AM (21 months ago)

Author:

dd32

Message:

Trac: Don't throw a JS error on non-ticket pages for non-Gardeners.

In r12415 I failed to gate the code properly which has caused a JS error, which caused some functionalities of the page to not be rendered for logged out users.

See #6783.

Location:

sites/trunk

Files:

• trac.wordpress.org/templates/site.html (modified) (1 diff)
• wordpress.org/public_html/style/trac/wp-trac.js (modified) (1 diff)

sites/trunk/trac.wordpress.org/templates/site.html

@@ -5 +5 @@
 
 <?python
-    scripts_version = '211'
+    scripts_version = '212'
     project_slug = req.environ['HTTP_HOST'].split(':')[0].split('.')[0]
     wporg_endpoint = 'https://make.wordpress.org/' + project_slug + '/'

sites/trunk/wordpress.org/public_html/style/trac/wp-trac.js

@@ -698 +698 @@
 
             // Remove task, or make a task ticket read only. This supports the ticket type being 'task' or 'task (blessed)'
-            if ( -1 !== elements.type.val().indexOf( 'task' ) ) {
-                elements.type.after('<input type="hidden" name="field_type" value="' + elements.type.val() + '" /> ' + elements.type.val() )
-                    .parent().css('vertical-align', 'middle').end()
-                    .remove();
-            } else {
-                elements.type.find('option[value*="task"]').remove();
+            if ( elements.type.length ) {
+                if ( -1 !== elements.type.val().indexOf( 'task' ) ) {
+                    elements.type.after('<input type="hidden" name="field_type" value="' + elements.type.val() + '" /> ' + elements.type.val() )
+                        .parent().css('vertical-align', 'middle').end()
+                        .remove();
+                } else {
+                    elements.type.find('option[value*="task"]').remove();
+                }
             }