Changeset 12614

Timestamp:

06/02/2023 04:54:09 AM (6 months ago)

Author:

dd32

Message:

Plugin Directory: Readme Validator: Don't encourage the use of Stable Tag: trunk for plugins.

Props Ipstenu.
Fixes #6987.
See #6380.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/readme/class-validator.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/readme/class-validator.php

@@ -122 +122 @@
         }
 
-        if ( empty( $readme->stable_tag ) ) {
-            $warnings[] = sprintf(
-                /* translators: 1: 'Stable tag', 2: /trunk/ SVN directory, 3: 'Stable tag: trunk' */
-                __( 'The %1$s field is missing.  Hint: If you treat %2$s as stable, put %3$s.', 'wporg-plugins' ),
+        if ( empty( $readme->stable_tag ) || str_contains( $readme->stable_tag, 'trunk' ) ) {
+            $warnings[] = sprintf(
+                /* translators: 1: 'Stable tag', 2: /trunk/ SVN directory */
+                __( 'The %1$s field is missing or invalid.  Note: We ask you no longer attempt to use %2$s as stable, so that all plugins can be rolled back.', 'wporg-plugins' ),
                 '<code>Stable tag</code>',
-                '<code>/trunk/</code>',
-                '<code>Stable tag: trunk</code>'
+                '<code>/trunk/</code>'
             );
         }