Changeset 12682

Timestamp:

07/03/2023 04:34:09 AM (3 years ago)

Author:

dd32

Message:

Login: Registration: Better error when a blank form is submitted.

Props nirupagajera.
Fixes #7107.

Location:

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-login

Files:

• functions-registration.php (modified) (1 diff)
• register.php (modified) (2 diffs)
• stylesheets/login.css (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-login/functions-registration.php

@@ -198 +198 @@
         if ( is_array( $login_or_email ) && isset( $login_or_email['pending_id'] ) ) {
                 return $login_or_email;
+        }
+
+        $login_or_email = trim( $login_or_email );
+        if ( ! $login_or_email ) {
+                return false;
         }
 

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-login/register.php

@@ -76 +76 @@
         <p class="login-username">
                 <label for="user_login"><?php _e( 'Username', 'wporg' ); ?></label>
-                <input type="text" name="user_login" id="user_login" class="input <?php if ( $error_user_login ) echo 'error'; ?>" value="<?php echo esc_attr( $user_login ) ?>" size="20" maxlength="60" />
+                <input type="text" name="user_login" id="user_login" class="input <?php if ( $error_user_login ) echo 'error'; ?>" value="<?php echo esc_attr( $user_login ) ?>" size="20" maxlength="60" data-pattern-after-blur="[0-9a-z]{0,60}" required />
                 <span class="small"><?php _e( 'Only lower case letters (a-z) and numbers (0-9) are allowed.', 'wporg' ); ?></span>
         </p>
@@ -92 +92 @@
         <p class="login-email">
                 <label for="user_email"><?php _e( 'Email', 'wporg' ); ?></label>
-                <input type="email" name="user_email" id="user_email" class="input <?php if ( $error_user_email ) echo 'error'; ?>" value="<?php echo esc_attr( $user_email ) ?>" size="20" maxlength="100" />
+                <input type="email" name="user_email" id="user_email" class="input <?php if ( $error_user_email ) echo 'error'; ?>" value="<?php echo esc_attr( $user_email ) ?>" size="20" maxlength="100" data-pattern-after-blur=".+@.+\..+" required />
                 <span class="small"><?php _e( 'A link to set your password will be sent here.', 'wporg' ); ?></span>
         </p>

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-login/stylesheets/login.css

@@ -374 +374 @@
 
 body.login form input.error,
-body.login form input:invalid {
+body.login form input[pattern]:invalid {
         background-color: #fbeaea;
         border: 2px solid #dc3232;