Changeset 12712 for sites/trunk/wordpress.org/public_html/wp-content/plugins/trac-notifications/trac-notifications-sqlite-driver.php

Timestamp:

07/05/2023 05:04:40 AM (17 months ago)

Author:

dd32

Message:

Trac: Add a custom API to fetch/set user preferences. Take Two.

See [12711].
See #5055.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/trac-notifications/trac-notifications-sqlite-driver.php (modified) (6 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/trac-notifications/trac-notifications-sqlite-driver.php

@@ -51 +51 @@
     }
 
+    /**
+     * Delete row(s) from a table.
+     *
+     * @return bool If the query ran.
+     */
     public function delete( $table, $where ) {
         $fields = 'AND ' . implode( ' = %s AND ', array_keys( $where ) ) . ' = %s';
@@ -57 +62 @@
             array_values( $where )
         );
-        $this->db->query( $query );
+        return (bool) $this->db->query( $query );
     }
 
+    /**
+     * Insert a row into a table.
+     *
+     * @return bool If the query ran.
+     */
     public function insert( $table, $args ) {
         $fields = "'" . implode( "', '", array_keys( $args ) ) . "'";
@@ -70 +80 @@
     }
 
+    /**
+     * Update a row in a table.
+     *
+     * @return bool If the query executed and modified rows.
+     */
     public function update( $table, $data, $wheres ) {
-        $values     = [];
-        $sql_sets   = [];
-        $sql_wheres = [];
+        $values     = array();
+        $sql_sets   = array();
+        $sql_wheres = array();
 
         foreach ( $data as $field => $value ) {
@@ -81 +96 @@
         $sql_sets = implode( ', ', $sql_sets );
 
-        foreach ( $wheres as $field => $where ) {
+        foreach ( $wheres as $field => $value ) {
             $sql_wheres[] = "$field = %s";
             $values[]     = $value;
@@ -87 +102 @@
         $sql_wheres = implode( ' AND ', $sql_wheres );
 
-        if ( ! $values ) {
+        if ( ! $values || ! $sql_wheres ) {
             return false;
         }
@@ -96 +111 @@
         );
 
-        return (bool) $this->db->query( $query );
+        $result = $this->db->query( $query );
+
+        return $result && $result->rowCount() > 0;
     }
 }