Changeset 12715 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-import.php

Timestamp:

07/06/2023 06:23:02 AM (3 years ago)

Author:

dd32

Message:

Plugin Directory: Import: When importing plugins from SVN, if the readme title is the plugin slug, ignore that and use the Plugin headers.

This affects a minority of plugins, but this improves a small set of plugins who have === plugin-slug-here === in their readme.txt.

See #6106.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-import.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-import.php

@@ -191 +191 @@
         }
 
-        // Fallback to the plugin title if the readme didn't contain it.
-        $plugin->post_title   = trim( $readme->name ) ?: strip_tags( $headers->Name ) ?: $plugin->post_title;
+        // Use the Readme name, as long as it's not the plugin slug.
+        if (
+            $readme->name &&
+            $readme->name !== $plugin->post_name
+        ) {
+            $plugin->post_title = $readme->name;
+        } elseif ( $headers->Name ) {
+            $plugin->post_title = strip_tags( $headers->Name );
+        }
+
         $plugin->post_content = trim( $content ) ?: $plugin->post_content;
         $plugin->post_excerpt = trim( $readme->short_description ) ?: $headers->Description ?: $plugin->post_excerpt;