Changeset 12751 for sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-translation-suggestions/inc/routes/class-translation-memory.php

Timestamp:

07/21/2023 09:49:35 AM (3 years ago)

Author:

spiraltee

Message:

Translate: Refactor code to log suggestion source for translations

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-translation-suggestions/inc/routes/class-translation-memory.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-translation-suggestions/inc/routes/class-translation-memory.php

@@ -483 +483 @@
 
         /**
-         * Updates the external translations used by each user.
+         * Update the number of external translations used.
          *
          * @return void
          */
-        public function update_external_translations() {
-                if ( ! isset( $_POST['nonce'] ) || ! wp_verify_nonce( $_POST['nonce'], 'wporg-editor-settings' ) ) {
-                        wp_send_json_error( array( 'message' => esc_html__( 'Invalid nonce.', 'glotpress' ) ), 403 );
-                }
-                if ( ! isset( $_POST['translation'] ) ) {
-                        wp_send_json_error( array( 'message' => esc_html__( 'Translation parameter is not present.', 'glotpress' ) ), 400 );
-                }
-                if ( ! isset( $_POST['openAITranslationsUsed'] ) && ! isset( $_POST['deeplTranslationsUsed'] ) ) {
-                        wp_send_json_error( array( 'message' => esc_html__( 'Translation suggested parameter is not present.', 'glotpress' ) ), 400 );
-                }
-                if ( isset( $_POST['openAITranslationsUsed'] ) ) {
-                        $this->update_one_external_translation(
-                                $_POST['translation'],
-                                $_POST['openAITranslationsUsed'],
-                                'openai_translations_used',
-                                'openai_same_translations_used'
-                        );
-                }
-                if ( isset( $_POST['deeplTranslationsUsed'] ) ) {
-                        $this->update_one_external_translation(
-                                $_POST['translation'],
-                                $_POST['deeplTranslationsUsed'],
-                                'deepl_translations_used',
-                                'deepl_same_translations_used'
-                        );
-                }
-                wp_send_json_success();
+        public function update_external_translations( $translation ) {
+                $is_source_set    = isset( $_POST['externalTranslationSource'] ) && isset( $_POST['externalTranslationUsed'] );
+                $is_request_valid = 'GP_Route_Translation' === GP::$current_route->class_name && 'translations_post' === GP::$current_route->last_method_called;
+                if ( ! $is_request_valid || ! $is_source_set || ! $translation ) {
+                        return;
+                }
+                self::update_one_external_translation(
+                        $translation->translation_0,
+                        sanitize_text_field( $_POST['externalTranslationSource'] ),
+                        sanitize_text_field( $_POST['externalTranslationUsed'] ),
+                );
         }
 
@@ -520 +504 @@
          *
          * @param string $translation                     The translation.
+         * @param string $suggestion_source               The suggestion_source.
          * @param string $suggestion                      The suggestion.
-         * @param string $external_translations_used      The external translations used.
-         * @param string $external_same_translations_used The external same translations used.
          *
          * @return void
          */
-        private function update_one_external_translation( string $translation, string $suggestion, string $external_translations_used, string $external_same_translations_used ) {
+        private static function update_one_external_translation( string $translation, string $suggestion_source, string $suggestion ) {
+                $external_translations_used      = $suggestion_source . '_translations_used';
+                $external_same_translations_used = $suggestion_source . '_same_translations_used';
+
                 $is_the_same_translation  = $translation == $suggestion;
                 $gp_external_translations = get_user_option( 'gp_external_translations' );