Changeset 12761

Timestamp:

07/26/2023 07:13:49 AM (3 years ago)

Author:

dd32

Message:

Slack: Don't send /here broadcasts to parent channels for certain groups, as it causes confusion.

Location:

sites/trunk/common/includes/slack/announce

Files:

• config.php (modified) (1 diff)
• lib.php (modified) (4 diffs)

sites/trunk/common/includes/slack/announce/config.php

@@ -96 +96 @@
             'sippis',
         ),
+        'contributor-mentorship' => $wordcamp_central,
         'core' => array_merge( get_committers(), array(
             'amykamala', // @amy kamala on Slack

sites/trunk/common/includes/slack/announce/lib.php

@@ -143 +143 @@
             $root = 'contributor-mentorship';
             break;
-        case 'contributor': // Such as #contributor-mentorship
         case 'community':
             $root = 'community-team';
@@ -173 +172 @@
     }
 
-    // Recurse, in case the parent channel has a parent channel.
-    // ie. #mentorship-cohort-july-2023 => #contributor-mentorship => #community-team
-    foreach ( $parent_channels as $parent_channel ) {
-        $parent_channels = array_merge( $parent_channels, get_parent_channels( $parent_channel ) ?: [] );
-    }
-
     return array_unique( $parent_channels ) ?: false;
 }
@@ -291 +284 @@
     }
 
+    // Don't send to these parent channels.
+    $dont_send_to = [
+        'contributor-mentorship',
+    ];
+
     $text = $data['text'];
     // Remove any @here or @channel
@@ -299 +297 @@
 
     foreach ( $parent_channels as $parent_channel ) {
+        if ( in_array( $parent_channel, $dont_send_to, true ) ) {
+            continue;
+        }
+
         $send->set_text( 'In #' . $channel . ': ' . $text );
         $send->send( '#' . $parent_channel );