Changeset 12765

Timestamp:

07/28/2023 03:17:38 PM (3 years ago)

Author:

spiraltee

Message:

Translate: Log other locale suggestions

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-translation-suggestions

Files:

• js/translation-suggestions.js (modified) (1 diff)
• templates/other-languages-suggestions.php (modified) (1 diff)
• templates/translation-memory-suggestions.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-translation-suggestions/js/translation-suggestions.js

@@ -479 +479 @@
                         return;
                 }
-                externalSuggestion.suggestion_source = $row.data( 'suggestion-source' ) == 'translation' ? 'tm' : $row.data( 'suggestion-source' );
-                externalSuggestion.translation = $row.find( '.translation-suggestion__translation' ).text();
-
+                if ( $row.data( 'suggestion-locale' ) ) {
+                        externalSuggestion.suggestion_source = $row.data( 'suggestion-locale' );
+                        externalSuggestion.translation = $row.find( '.translation-suggestion__translation-raw' ).text();
+                } else {
+                        externalSuggestion.suggestion_source = $row.data( 'suggestion-source' );
+                        externalSuggestion.translation = $row.find( '.translation-suggestion__translation' ).text();
+                }
         }
 
         //Prefilter ajax requests to add external translations used to the request.
         $.ajaxPrefilter( function ( options ) {
-                const isSuggestionUsed = Object.keys( externalSuggestion ).length  > 0 ? true : false;
-
-                if ( ! externalSuggestion || ! isSuggestionUsed ) {
+                if ( ! externalSuggestion || ! externalSuggestion.suggestion_source || ! externalSuggestion.translation ) {
                         return;
                 }

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-translation-suggestions/templates/other-languages-suggestions.php

@@ -7 +7 @@
         foreach ( $suggestions as $suggestion ) {
                 echo '<li>';
-                echo '<div class="translation-suggestion with-tooltip" tabindex="0" role="button" aria-pressed="false" aria-label="Copy translation">';
+                echo '<div class="translation-suggestion with-tooltip" tabindex="0" role="button" data-suggestion-locale="' . esc_html( strtolower( $suggestion['locale'] ) ) . '" aria-pressed="false" aria-label="Copy translation">';
 
                         echo '<span class="translation-suggestion__translation">';

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-translation-suggestions/templates/translation-memory-suggestions.php

@@ -5 +5 @@
         echo '<ul class="suggestions-list">';
         foreach ( $suggestions as $suggestion ) {
+                $suggestion_type = ( 'translation' === strtolower( $type ) ) ? 'tm' : $type;
+
                 echo '<li>';
-                echo '<div class="translation-suggestion with-tooltip ' . esc_html( strtolower( $type ) ) . '" tabindex="0" data-suggestion-source="' . esc_html( strtolower( $type ) ) . '" role="button" aria-pressed="false" aria-label="Copy translation">';
+                echo '<div class="translation-suggestion with-tooltip ' . esc_html( strtolower( $type ) ) . '" tabindex="0" data-suggestion-source="' . esc_html( strtolower( $suggestion_type ) ) . '" role="button" aria-pressed="false" aria-label="Copy translation">';
                         echo '<span class="' . esc_html( strtolower( $type ) ) . '-suggestion__score">';
                 if ( 'Translation' == $type ) {