Changeset 12784

Timestamp:

08/01/2023 10:41:25 PM (3 years ago)

Author:

coffee2code

Message:

Photo Directory, Admin JS: Prevent some JS warnings/errors when run in other contexts.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/photo-directory/assets/js/admin.js (modified) (4 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/photo-directory/assets/js/admin.js

@@ -19 +19 @@
     // Hide 'Orientations' metabox when a value is assigned.
     //  Orientation shouldn't need direct assignment or changing, so don't show it (as long as a value was set).
-    const orientation_value = document.querySelector('input[name="tax_input[photo_orientation][]"]:checked' );
-    if ( orientation_value ) {
-        document.getElementById('photo_orientationdiv').hidden = true;
+    const orientationValue = document.querySelector('input[name="tax_input[photo_orientation][]"]:checked' );
+    const orientationDiv = document.getElementById('photo_orientationdiv');
+    if ( orientationValue && orientationDiv ) {
+        orientationDiv.hidden = true;
     }
 
@@ -60 +61 @@
 
         // The tag list is handled differently. Re-determine as tags are added/removed.
-        if (element[3]) {
+        const tagList = element[3] ? document.querySelector(element[3]) : null;
+        if (tagList) {
             const observer = new MutationObserver(function(mutations_list) {
                 mutations_list.forEach(function(mutation) {
@@ -69 +71 @@
             });
 
-            observer.observe(document.querySelector(element[3]), { subtree: false, childList: true });
+            observer.observe(tagList, { subtree: false, childList: true });
         }
     });
@@ -96 +98 @@
         // If tagListClass is present, see if it has any values if one not already found.
         if (!value && tagListClass) {
-            value = document.querySelector(tagListClass).hasChildNodes();
+            value = document.querySelector(tagListClass)?.hasChildNodes();
         }