Changeset 12802

Timestamp:

08/03/2023 02:13:10 AM (3 years ago)

Author:

dd32

Message:

Support Forums: Use a dedicated meta_key for the post-as-moderator functionality to avoid other moderation actions overwriting the value.

See #6839.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-moderators.php (modified) (4 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-moderators.php

@@ -5 +5 @@
 class Moderators {
 
-        const ARCHIVED       = 'archived';
-        const ARCHIVED_META  = '_wporg_bbp_unarchived_post_status';
-        const MODERATOR_META = '_wporg_bbp_moderator';
-        const DEFAULT_STATUS = 'publish';
-        const VIEWS          = array( 'archived', 'pending', 'spam' );
+        const ARCHIVED               = 'archived';
+        const ARCHIVED_META          = '_wporg_bbp_unarchived_post_status';
+        const MODERATOR_META         = '_wporg_bbp_moderator';
+        const MODERATOR_REPLY_AUTHOR = '_wporg_bbp_moderator_reply_author';
+        const DEFAULT_STATUS         = 'publish';
+        const VIEWS                  = array( 'archived', 'pending', 'spam' );
 
         public function __construct() {
@@ -1158 +1159 @@
                 // Record the real user in the post meta.
                 $post_data['meta_input'] ??= [];
-                $post_data['meta_input'][ self::MODERATOR_META ] = get_current_user_id();
+                $post_data['meta_input'][ self::MODERATOR_REPLY_AUTHOR ] = get_current_user_id();
 
                 return $post_data;
@@ -1176 +1177 @@
                 }
 
-                $user = get_user_by( 'id', get_post_meta( bbp_get_reply_id(), self::MODERATOR_META, true ) );
+                $user = get_user_by( 'id', get_post_meta( bbp_get_reply_id(), self::MODERATOR_REPLY_AUTHOR, true ) );
 
                 printf(
@@ -1187 +1188 @@
         /**
          * Pretend the @moderator user can moderate, except when they're logged in.
+         *
+         * This keeps the moderator account as a low-access account, while also showing the replies
+         * with a moderator badge. This should probably ideally be a filter on the badges.
          */
         public function anon_moderator_user_has_cap( $allcaps, $caps, $args, $user ) {