Changeset 12813 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/api/routes/class-plugin-release-confirmation.php

Timestamp:

08/08/2023 05:14:08 AM (3 years ago)

Author:

dd32

Message:

Plugin Directory: Allow plugins releases to be discarded instead of confirmed.

Sometimes a release should not be released, this allows discarding those releases to cease the warnings.

See #5352.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/api/routes/class-plugin-release-confirmation.php (modified) (5 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/api/routes/class-plugin-release-confirmation.php

@@ -45 +45 @@
                                 ]
                         ],
-                        'permission_callback' => function( $request ) {
-                                $plugin = Plugin_Directory::get_plugin_post( $request['plugin_slug'] );
-
-                                return (
-                                        Release_Confirmation_Shortcode::can_access() &&
-                                        current_user_can( 'plugin_manage_releases', $plugin )
-                                );
-                        },
+                        'permission_callback' => [ $this, 'permission_can_access_plugin' ],
+                ] );
+
+                register_rest_route( 'plugins/v1', '/plugin/(?P<plugin_slug>[^/]+)/release-confirmation/(?P<plugin_tag>[^/]+)/discard', [
+                        'methods'             => \WP_REST_Server::READABLE, // TODO: This really should be a POST
+                        'callback'            => [ $this, 'discard_release' ],
+                        'args'                => [
+                                'plugin_slug' => [
+                                        'validate_callback' => [ $this, 'validate_plugin_slug_callback' ],
+                                ],
+                                'plugin_tag' => [
+                                        'validate_callback' => [ $this, 'validate_plugin_tag_callback' ],
+                                ]
+                        ],
+                        'permission_callback' => [ $this, 'permission_can_access_plugin' ],
                 ] );
 
@@ -87 +94 @@
 
         /**
+         * Validate that the user can manage releases for the given plugin.
+         */
+        public function permission_can_access_plugin( $request ) {
+                $plugin = Plugin_Directory::get_plugin_post( $request['plugin_slug'] );
+
+                return (
+                        Release_Confirmation_Shortcode::can_access() &&
+                        current_user_can( 'plugin_manage_releases', $plugin )
+                );
+        }
+
+        /**
          * Endpoint to self-close a plugin.
          *
@@ -154 +173 @@
                 header( 'Location: ' . $result['location'] );
 
-                if ( ! $release || ! empty( $release['confirmed'][ $user_login ] ) ) {
-                        // Already confirmed.
+                if ( ! $release || ! empty( $release['confirmed'][ $user_login ] ) || ! empty( $release['discarded'] ) ) {
+                        // Already confirmed, or unable to be confirmed.
                         $result['confirmed'] = false;
                         return $result;
@@ -166 +185 @@
                 // Mark the release as confirmed if enough confirmations.
                 if ( count( $release['confirmations'] ) >= $release['confirmations_required'] ) {
-                        $release['confirmed'] = true;
-                        $result['fully_confirmed']     = true;
+                        $release['confirmed']      = true;
+                        $result['fully_confirmed'] = true;
                 }
 
@@ -193 +212 @@
 
         /**
+         * A simple endpoint to decline/discard a release.
+         */
+        public function discard_release( $request ) {
+                $user_login = wp_get_current_user()->user_login;
+                $plugin     = Plugin_Directory::get_plugin_post( $request['plugin_slug'] );
+                $tag        = $request['plugin_tag'];
+                $release    = Plugin_Directory::get_release( $plugin, $tag );
+                $result     = [
+                        'location' => wp_get_referer() ?: home_url( '/developers/releases/' ),
+                ];
+                header( 'Location: ' . $result['location'] );
+
+                if ( ! $release || $release['confirmed'] || ! empty( $release['discarded'] ) ) {
+                        // Already confirmed, or other error encountered.
+                        $result['confirmed'] = false;
+                        return $result;
+                }
+
+                // Record this user as discarding the release.
+                $release['confirmed'] = false; // Already false, just noting it here explicitely.
+                $release['discarded'] = [
+                        'user' => $user_login,
+                        'time' => time(),
+                ];
+
+                Plugin_Directory::add_release( $plugin, $release );
+
+                return $result;
+        }
+
+        /**
          * Send a Access email
          */