Changeset 12821

Timestamp:

08/09/2023 07:25:03 PM (16 months ago)

Author:

coffee2code

Message:

Jobs theme: Add missing 'id' attribute to input fields to associate them with their labels.

Props viralsampat, dd32, coffee2code.
See #6695.

File:

• sites/trunk/jobs.wordpress.net/public_html/wp-content/themes/jobswp/content-post-job.php (modified) (7 diffs)

sites/trunk/jobs.wordpress.net/public_html/wp-content/themes/jobswp/content-post-job.php

@@ -48 +48 @@
         <label for="howtoapply"><?php _e( 'How to Apply', 'jobswp' ); ?>* <span><?php _e( '(also specify)', 'jobswp' ); ?></span></label>
         <div class="howtoapply-inputs">
-            <select name="howtoapply_method" class="<?php echo jobswp_required_field_classes( 'howtoapply_method' ); ?>" required>
+            <select name="howtoapply_method" id="howtoapply_method" class="<?php echo esc_attr( jobswp_required_field_classes( 'howtoapply_method' ) ); ?>" required>
                 <option value="" selected="selected" disabled="disabled"></option>
                 <option value="email" <?php echo jobswp_field_value( 'howtoapply_method', 'email' ); ?>><?php _e( 'Email Address', 'jobswp' ); ?></option>
@@ -54 +54 @@
                 <option value="web" <?php echo jobswp_field_value( 'howtoapply_method', 'web' ); ?>><?php _e( 'Online Form', 'jobswp' ); ?></option>
             </select> :
-            <input type="text" name="howtoapply" class="<?php echo jobswp_required_field_classes( 'howtoapply' ); ?>" <?php echo jobswp_field_value( 'howtoapply' ); ?> />
+            <input type="text" name="howtoapply" id="howtoapply" class="<?php echo esc_attr( jobswp_required_field_classes( 'howtoapply' ) ); ?>" <?php echo jobswp_field_value( 'howtoapply' ); ?> />
         </div>
 
@@ -81 +81 @@
         <div class="post-job-input">
             <label for="category"><?php _e( 'Category', 'jobswp' ); ?>*</label>
-            <select name="category" class="<?php echo jobswp_required_field_classes( 'category' ); ?>" required>
+            <select name="category" id="category" class="<?php echo jobswp_required_field_classes( 'category' ); ?>" required>
                 <option value="" selected="selected" disabled="disabled"></option>
                 <?php foreach ( Jobs_Dot_WP::get_job_categories() as $cat ) : ?>
@@ -91 +91 @@
         <div class="post-job-input">
             <label for="jobtype"><?php _e( 'Job Type', 'jobswp' ); ?>*</label>
-            <select name="jobtype" class="<?php echo jobswp_required_field_classes( 'jobtype' ); ?>" required>
+            <select name="jobtype" id="jobtype" class="<?php echo esc_attr( jobswp_required_field_classes( 'jobtype' ) ); ?>" required>
                 <option value="" selected="selected" disabled="disabled"></option>
                 <option value="ft" <?php echo jobswp_field_value( 'jobtype', 'ft' ); ?>><?php _e( 'Full Time', 'jobswp' ); ?></option>
@@ -105 +105 @@
 
         <div class="post-job-input">
-            <label for="job_title"><?php _e( 'Job Description', 'jobswp' ); ?>*</label>
-            <textarea name="job_description" rows="10" class="<?php echo jobswp_required_field_classes( 'job_description' ); ?>"><?php echo jobswp_field_value( 'job_description' ); ?></textarea>
+            <label for="job_description"><?php _e( 'Job Description', 'jobswp' ); ?>*</label>
+            <textarea name="job_description" id="job_description" rows="10" class="<?php echo jobswp_required_field_classes( 'job_description' ); ?>"><?php echo jobswp_field_value( 'job_description' ); ?></textarea>
             <p><?php echo sprintf( __( 'Line and paragraph breaks are automatic. <acronym title="Hypertext Markup Language">HTML</acronym> allowed: <code>%s</code>', 'jobswp' ), jobswp_allowed_tags() ); ?></p>
             <p><?php _e( 'All job postings are moderated prior to appearing on the site.', 'jobswp' ); ?></p>
@@ -136 +136 @@
             </ul>
             <p>
-                <input type="checkbox" name="accept" value="1" required /><label for="accept"><?php _e( 'I agree to the terms stated above.', 'jobswp' ); ?>*</label>
+                <input type="checkbox" name="accept" id="accept" value="1" required /><label for="accept"><?php _e( 'I agree to the terms stated above.', 'jobswp' ); ?>*</label>
             </p>
         </div>
@@ -142 +142 @@
         $button_label = __( 'Submit Job', 'jobswp' );
     } ?>
-    <input class="submit-job" type="submit" name="submitjob" value="<?php echo esc_attr( $button_label ); ?>" />
+    <input class="submit-job" id="submit-job" type="submit" name="submitjob" value="<?php echo esc_attr( $button_label ); ?>" />
 </div>