Changeset 12823

Timestamp:

08/09/2023 07:29:59 PM (4 months ago)

Author:

coffee2code

Message:

Jobs plugin: Add missing 'id' attribute to input fields to associate them with their labels.

Also change to late-escape attributes and improve markup construction.

Props viralsampat, dd32, coffee2code.
Fixes #6695.

File:

• sites/trunk/jobs.wordpress.net/public_html/wp-content/plugins/jobswp/jobswp-template.php (modified) (2 diffs)

sites/trunk/jobs.wordpress.net/public_html/wp-content/plugins/jobswp/jobswp-template.php

@@ -128 +128 @@
  */
 function jobswp_text_field( $field_name, $field_label, $required = false, $type = 'text', $help_text = '' ) {
-    $field_name  = esc_attr( $field_name );
-    $field_label = esc_html( $field_label );
-
-    echo '<div class="post-job-input post-job-input-' . $field_name . '">' . "\n";
-    echo "<label for='$field_name'>$field_label" . ( $required ? '*' : '' ) . "</label>\n";
+    echo '<div class="post-job-input post-job-input-' . esc_attr( $field_name ) . '">' . "\n";
+    echo '<label for="' . esc_attr( $field_name ) . '">' . esc_html( $field_label ) . ( $required ? '*' : '' ) . "</label>\n";
 
     $html5_input_types = array( 'color', 'date', 'datetime', 'datetime-local', 'email', 'month', 'number',
@@ -139 +136 @@
         $type = 'text';
 
-    echo "<input type='$type' name='$field_name' class='" .
-        ( $required ? jobswp_required_field_classes( $field_name ) : '' ) .
-        "' " .
-        jobswp_field_value( $field_name ) .
-        ( $required ? ' required' : '' ) .
-        " />\n";
+    $classes = $required ? jobswp_required_field_classes( $field_name ) : '';
+    printf(
+        '<input type="%s" name="%s" id="%s" class="%s" %s%s />' . "\n",
+        esc_attr( $type ),
+        esc_attr( $field_name ),
+        esc_attr( $field_name ),
+        esc_attr( $classes ),
+        jobswp_field_value( $field_name ),
+        ( $required ? ' required' : '' )
+    );
 
     if ( $help_text ) {