Changeset 1285 for sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-upload.php

Timestamp:

02/19/2015 10:42:25 PM (10 years ago)

Author:

obenland

Message:

WP.org Themes: Improve check for pre-existing themes.

We need to specify post stati, so the check for an existing theme doesn't fail
for users who lack the ability to preview drafts.

See #745.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-upload.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-upload.php

@@ -277 +277 @@
             'post_type'        => 'repopackage',
             'orderby'          => 'ID',
-            'post_status'      => 'any',
+
+            /*
+             * Specify post stati so this query returns a result for draft themes, even
+             * if the uploading user doesn't have have the permission to view drafts.
+             */
+            'post_status'      => array( 'publish', 'pending', 'draft', 'future' ),
             'suppress_filters' => false,
         ) );
-
-        $theme = array_pop( $themes );
+        $theme = current( $themes );
 
         if ( ! empty( $theme ) ) {