Changeset 12936

Timestamp:

10/06/2023 10:27:46 PM (3 years ago)

Author:

iandunn

Message:

Events: Only search Geonames for places with populations > 500

This ensures that searching for Genova will find the populated city with events, rather than the small village with no events.

It seems unlikely that they'll be a meetup in town with < 500, but we can revisit this if we run into that. The smallest place I saw with a meetup had a population of around 6,000.

Location:

sites/trunk/api.wordpress.org/public_html/events/1.0

Files:

• index.php (modified) (2 diffs)
• tests/test-index.php (modified) (1 diff)

sites/trunk/api.wordpress.org/public_html/events/1.0/index.php

@@ -391 +391 @@
     global $wpdb;
     // Look for a location that matches the name.
-    // The asc ordering provides preference to the oreferred name of the locations.
+    // The asc ordering provides preference to the preferred name of the locations.
     // The population ordering provides preference to the populated areas over unpopulated/unknown.
+    //    It's unlikely an area with less than ~500 people would hold an event, but sometimes those places rank
+    //    higher than populated areas due to the alt vs primary name. See `Genova` unit tests
     // The FIELD() orderings give preference to rows that match the country and/or timezone, without excluding rows that don't match.
     // And we sort by population desc, assuming that the biggest matching location is the most likely one within the above matching groups.
@@ -404 +406 @@
             FIELD( %s, country ) DESC,
             alt ASC,
-            population > 0 DESC,
+            population > 500 DESC,
             FIELD( %s, timezone ) DESC,
             LEFT( type, 1 ) = "P" DESC,

sites/trunk/api.wordpress.org/public_html/events/1.0/tests/test-index.php

@@ -1077 +1077 @@
             ),
 
+            // Genova, IT is the native name of a populated city, and it's English name is Genoa. There's also a
+            // small village in IT whose English name is Genova. Geonames considers the English name to be the
+            // primary one, and native names are considered alternate names. We rank primary names higher than
+            // alternate names, and that usually works, but in this case people are more likely to be looking for
+            // the city.
+            'rural-match-less-likely-than-city-match' => array(
+                'input' => array(
+                    'location_name' => 'Genova',
+                    'locale'        => 'it_IT',
+                    'timezone'      => 'Europe/Rome',
+                ),
+                'expected' => array(
+                    'description' => 'genova',
+                    'latitude'    => '44.413',
+                    'longitude'   => '8.957',
+                    'country'     => 'IT',
+                ),
+            ),
+
+            'rural-match-less-likely-than-city-match-with-accent' => array(
+                'input' => array(
+                    'location_name' => 'Gènova',
+                    'locale'        => 'it_IT',
+                    'timezone'      => 'Europe/Rome',
+                ),
+                'expected' => array(
+                    'description' => 'genova',
+                    'latitude'    => '44.413',
+                    'longitude'   => '8.957',
+                    'country'     => 'IT',
+                ),
+            ),
+
+            'city-match-more-likely-than-rural-match' => array(
+                'input' => array(
+                    'location_name' => 'Genoa',
+                    'locale'        => 'it_IT',
+                    'timezone'      => 'Europe/Rome',
+                ),
+                'expected' => array(
+                    'description' => 'genoa',
+                    'latitude'    => '44.405',
+                    'longitude'   => '8.944',
+                    'country'     => 'IT',
+                ),
+            ),
+
             /*
              * A combination of city, region, and country are given, along with the locale and timezone