Changeset 12936 for sites/trunk/api.wordpress.org/public_html/events/1.0/index.php

Timestamp:

10/06/2023 10:27:46 PM (21 months ago)

Author:

iandunn

Message:

Events: Only search Geonames for places with populations > 500

This ensures that searching for Genova will find the populated city with events, rather than the small village with no events.

It seems unlikely that they'll be a meetup in town with < 500, but we can revisit this if we run into that. The smallest place I saw with a meetup had a population of around 6,000.

File:

• sites/trunk/api.wordpress.org/public_html/events/1.0/index.php (modified) (2 diffs)

sites/trunk/api.wordpress.org/public_html/events/1.0/index.php

@@ -391 +391 @@
     global $wpdb;
     // Look for a location that matches the name.
-    // The asc ordering provides preference to the oreferred name of the locations.
+    // The asc ordering provides preference to the preferred name of the locations.
     // The population ordering provides preference to the populated areas over unpopulated/unknown.
+    //    It's unlikely an area with less than ~500 people would hold an event, but sometimes those places rank
+    //    higher than populated areas due to the alt vs primary name. See `Genova` unit tests
     // The FIELD() orderings give preference to rows that match the country and/or timezone, without excluding rows that don't match.
     // And we sort by population desc, assuming that the biggest matching location is the most likely one within the above matching groups.
@@ -404 +406 @@
             FIELD( %s, country ) DESC,
             alt ASC,
-            population > 0 DESC,
+            population > 500 DESC,
             FIELD( %s, timezone ) DESC,
             LEFT( type, 1 ) = "P" DESC,