Changeset 12996

Timestamp:

12/04/2023 01:21:51 AM (2 years ago)

Author:

dd32

Message:

HelpScout: Properly detect the plugin for an email when the plugin name contains characters that would be HTML escaped within the database.

For example, this previously failed with the plugin title A & B which is stored as A & B.

File:

• sites/trunk/api.wordpress.org/public_html/dotorg/helpscout/common.php (modified) (1 diff)

sites/trunk/api.wordpress.org/public_html/dotorg/helpscout/common.php

@@ -290 +290 @@
         switch_to_blog( WPORG_PLUGIN_DIRECTORY_BLOGID );
         $plugins = get_posts( [
-            'title'       => trim( $m['title'] ),
+            // Post titles are always escaped.
+            'title'       => esc_html( trim( $m['title'] ) ),
             'post_type'   => 'plugin',
             'post_status' => 'any',
         ] );
+
+        // Although the above should always catch it, let's try again with the unescaped title.
+        if ( ! $plugins ) {
+            $plugins = get_posts( [
+                'title'       => trim( $m['title'] ),
+                'post_type'   => 'plugin',
+                'post_status' => 'any',
+            ] );
+        }
         restore_current_blog();