Changeset 13017 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/class-customizations.php

Timestamp:

12/06/2023 04:28:05 AM (3 years ago)

Author:

dd32

Message:

Plugin Directory: Reviewer tools: Make the Reviewer column sortable.

Fixes #7147.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/class-customizations.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/class-customizations.php

@@ -30 +30 @@
                 add_filter( 'dashboard_glance_items', array( $this, 'plugin_glance_items' ) );
 
+                add_filter( 'query_vars', array( $this, 'query_vars' ) );
                 add_action( 'pre_get_posts', array( $this, 'pre_get_posts' ) );
 
@@ -190 +191 @@
 
         /**
+         * Filter the query vars used in wp-admin.
+         */
+        public function query_vars( $query_vars ) {
+                $query_vars[] = 'reviewer';
+
+                return $query_vars;
+        }
+
+        /**
          * Filter the query in wp-admin to list only plugins relevant to the current user.
          *
@@ -215 +225 @@
 
                 // Filter by reviewer.
-                if ( ! empty( $_REQUEST['reviewer'] ) ) {
+                if ( isset( $query->query['reviewer'] ) && strlen( $query->query['reviewer'] ) ) {
                         $meta_query = $query->get( 'meta_query' ) ?: [];
-                        $meta_query[] = [
+                        $meta_query['assigned_reviewer'] = [
                                 'key'   => 'assigned_reviewer',
-                                'value' => intval( $_GET['reviewer'] ),
+                                'value' => intval( $query->query['reviewer'] ),
+                                'type'  => 'unsigned',
+                        ];
+
+                        // Query for no assignee.
+                        if ( ! $meta_query['assigned_reviewer']['value'] ) {
+                                $meta_query['assigned_reviewer']['compare'] = 'NOT EXISTS';
+                        }
+
+                        $query->set( 'meta_query', $meta_query );
+                }
+
+                if ( 'assigned_reviewer_time' === $query->query['orderby'] ?? '' ) {
+                        $meta_query = $query->get( 'meta_query' ) ?: [];
+
+                        $meta_query['assigned_reviewer_time'] = [
+                                'key'     => 'assigned_reviewer_time',
+                                'type'    => 'unsigned',
                         ];