Changeset 13024

Timestamp:

12/07/2023 08:38:27 AM (3 years ago)

Author:

dd32

Message:

Plugin Directory: Reviewer Tools: Make the Zip & LOC columns sortable, cleanup the sort metadata after the ZIP is removed.

See #7285.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory

Files:

• admin/class-customizations.php (modified) (2 diffs)
• admin/list-table/class-plugin-posts.php (modified) (1 diff)
• jobs/class-zip-cleanup.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/class-customizations.php

@@ -241 +241 @@
                 }
 
-                if ( 'assigned_reviewer_time' === $query->query['orderby'] ?? '' ) {
+                $orderby                    = $query->query['orderby'] ?? '';
+                $possible_orderby_meta_keys = [
+                        'assigned_reviewer_time',
+                        '_submitted_zip_loc',
+                        '_submitted_zip_size',
+                ];
+                if ( in_array( $orderby, $possible_orderby_meta_keys, true ) ) {
                         $meta_query = $query->get( 'meta_query' ) ?: [];
 
-                        $meta_query['assigned_reviewer_time'] = [
-                                'key'     => 'assigned_reviewer_time',
+                        $meta_query[ $orderby ] = [
+                                'key'     => $orderby,
                                 'type'    => 'unsigned',
                         ];
@@ -251 +257 @@
                         $query->set( 'meta_query', $meta_query );
                 }
-
         }
 

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/list-table/class-plugin-posts.php

@@ -667 +667 @@
                 }
 
-                $attachments = get_posts( [
-                        'post_parent'    => $post->ID,
-                        'post_type'      => 'attachment',
-                        'post_mime_type' => 'application/zip',
-                        'posts_per_page' => 1,
-                        'orderby'        => 'post_date',
-                        'order'          => 'DESC',
-                ] )[0];
-
                 foreach ( get_attached_media( 'application/zip', $post ) as $zip_file ) {
                         $zip_size = size_format( filesize( get_attached_file( $zip_file->ID ) ), 1 );

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-zip-cleanup.php

@@ -84 +84 @@
                         }
 
+                        // Cleanup ZIP-related metadata.
+                        delete_post_meta( $plugin->ID, '_submitted_zip_size' );
+                        delete_post_meta( $plugin->ID, '_submitted_zip_loc' );
+
                         // Include some log output for debugging.
                         $filename = basename( wp_get_attachment_url( $attachment->ID ) );