Changeset 13026

Timestamp:

12/07/2023 05:14:02 PM (12 months ago)

Author:

ashfame

Message:

[matrix] always treat #matrix-testing room as testground, never posting on Trac from there

File:

• sites/trunk/api.wordpress.org/public_html/dotorg/matrix/trac-bot.php (modified) (4 diffs)

sites/trunk/api.wordpress.org/public_html/dotorg/matrix/trac-bot.php

@@ -14 +14 @@
 namespace Dotorg\Matrix\Trac {
 
-    define( 'DISABLE_TRAC_TICKETS_UPDATION', true ); // For testing, this prevents test stuff to be posted on Trac tickets.
     define( 'REPOST_MATRIX_LINK_TIME', 300 ); // 5 mins
     define( 'REPOST_TRAC_COMMENT_TIME', 7200 ); // 2 hrs
@@ -33 +32 @@
 
     $room_alias_local_part = ltrim( explode( ':', $_POST['room_alias'] )[0], '#' );
+
+    define( 'IS_MATRIX_TESTING_ROOM', $room_alias_local_part === 'matrix-testing' );
 
     // Prevent frequent posting to both Matrix & Trac using Redundancy Manager.
@@ -120 +121 @@
         }
 
-        if ( ! DISABLE_TRAC_TICKETS_UPDATION ) {
+        if ( ! IS_MATRIX_TESTING_ROOM ) {
             if ( defined( TRACBOT_WPORG_PASSWORD ) && ! empty( TRACBOT_WPORG_PASSWORD ) ) {
                 $trac_xmlrpc = new \Trac( 'matrixbot', TRACBOT_WPORG_PASSWORD, "https://$trac.trac.wordpress.org/login/xmlrpc" );
@@ -152 +153 @@
             $redundancy_manager->set( 'trac', $trac, 'ticket', $ticket_id );
 
-            if ( ! DISABLE_TRAC_TICKETS_UPDATION ) {
+            if ( ! IS_MATRIX_TESTING_ROOM ) {
                 isset( $trac_xmlrpc ) && $trac_xmlrpc->ticket_update( $ticket_id, $trac_comment );
+            } else {
+                $matrix_message[] = "[$trac] Trac comment: " . $trac_comment;
             }
         }