Changeset 13034

Timestamp:

12/08/2023 04:07:07 AM (9 months ago)

Author:

dd32

Message:

Plugin Directory: Reviewer tools: More consistent UI for the extra columns, and hide irrelevant columns for non-pending views.

See #7285.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/list-table/class-plugin-posts.php (modified) (4 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/list-table/class-plugin-posts.php

@@ -27 +27 @@
         add_filter( "manage_{$this->screen->post_type}_posts_columns", [ $this, 'filter_columns' ], 100 );
         add_filter( "manage_{$this->screen->id}_sortable_columns", [ $this, 'filter_sortable_columns' ], 100 );
+        add_filter( 'hidden_columns', [ $this, 'filter_hidden_columns' ], 100, 3 );
     }
 
@@ -55 +56 @@
         $columns[ 'zip' ]      = [ '_submitted_zip_size', 'asc' ];
         $columns[ 'loc' ]      = [ '_submitted_zip_loc', 'asc' ];
+
+        return $columns;
+    }
+
+    /**
+     * Hide some fields by default.
+     */
+    public function filter_hidden_columns( $columns, $screen, $use_defaults ) {
+        if ( $screen->id !== $this->screen->id ) {
+            return $columns;
+        }
+
+        // Hide certain columns on default / published views.
+        if (
+            in_array( $_REQUEST['post_status'] ?? 'all', [ 'all', 'publish', 'disabled', 'closed' ] ) &&
+            empty( $_REQUEST['author'] ) &&
+            empty( $_REQUEST['reviewer'] )
+        ) {
+            $columns[] = 'reviewer';
+            $columns[] = 'zip';
+            $columns[] = 'loc';
+        }
 
         return $columns;
@@ -668 +691 @@
                 )
             );
+        } else {
+            echo '-';
         }
     }
 
     public function column_zip( $post ) {
-        if ( ! in_array( $post->post_status, [ 'new', 'pending', 'approved' ] ) ) {
+        $media = get_attached_media( 'application/zip', $post );
+
+        if ( ! $media || ! in_array( $post->post_status, [ 'new', 'pending', 'approved' ] ) ) {
             echo '-';
             return;
         }
 
-        foreach ( get_attached_media( 'application/zip', $post ) as $zip_file ) {
+        foreach ( $media as $zip_file ) {
             $zip_size = size_format( filesize( get_attached_file( $zip_file->ID ) ), 1 );
 
@@ -694 +721 @@
 
     public function column_loc( $post ) {
-        echo number_format_i18n( $post->_submitted_zip_loc );
+        if ( ! in_array( $post->post_status, [ 'new', 'pending', 'approved' ] ) ) {
+            echo '-';
+            return;
+        }
+
+        echo number_format_i18n( (int) $post->_submitted_zip_loc ) ?: '-';
     }
 }