Changeset 13042

Timestamp:

12/08/2023 04:06:15 PM (3 years ago)

Author:

ashfame

Message:

[matrix] trac bot - bail if room alias is empty

File:

• sites/trunk/api.wordpress.org/public_html/dotorg/matrix/trac-bot.php (modified) (2 diffs)

sites/trunk/api.wordpress.org/public_html/dotorg/matrix/trac-bot.php

@@ -18 +18 @@
 
         // Simulate a webhook request.
-        // $_GET['secret'] = URL_SECRET__TRAC_BOT;
+        // $_POST['secret'] = URL_SECRET__TRAC_BOT;
         // $_POST['text'] = 'Hello #40007 and #1232-bbpress'; // Or 'Hello #1232-bbpress'
         // $_POST['user_id'] = '@admin:matrix.test';
         // $_POST['room_id'] = '!XXXXXXXX:matrix.test';
-        // $_POST['room_alias'] = '#sandbox:matrix.test';
+        // $_POST['room_alias'] = '#matrix-testing:matrix.test';
         // $_POST['event_id'] = '$HHHHHHHHHHHHH';
 
@@ -28 +28 @@
         if ( ! isset( $_POST['secret'] ) || $_POST['secret'] !== URL_SECRET__TRAC_BOT ) {
                 http_response_code( 403 );
+                return;
+        }
+
+        // room_name and room_alias can be empty for rooms not published in room directory
+        if ( empty( $_POST['room_alias'] ) ) {
+                http_response_code( 204 );
                 return;
         }