Changeset 13071

Timestamp:

12/19/2023 07:07:11 AM (12 months ago)

Author:

dd32

Message:

Plugin Directory: Downloads: Try a 302 redirect on the latest-stable.zip url to ensure browsers don't cache a stale version when using blueprints.

The playground ran into an issue that the .latest-stable.zip endpoint didn't expose any caching headers, which caused browsers to more aggressively cache the response, leading to previews loading previous versions.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/zip/class-serve.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/zip/class-serve.php

@@ -17 +17 @@
         try {
             $request = $this->determine_request();
+
+            $this->maybe_redirect_latest_stable( $request );
 
             $this->serve_zip( $request );
@@ -56 +58 @@
             $version = $m['version'];
         }
-        if ( 'latest-stable' == $version ) {
+
+        // If the latest-stable is requested, determine the file to serve.
+        $is_latest_stable = ( 'latest-stable' == $version );
+        if ( $is_latest_stable ) {
             $version = $this->get_stable_tag( $slug );
         }
@@ -79 +84 @@
         }
 
-        return compact( 'zip', 'slug', 'version', 'args', 'checksum_request', 'signature_request' );
+
+        return compact( 'zip', 'slug', 'version', 'args', 'checksum_request', 'signature_request', 'is_latest_stable' );
+    }
+
+    /**
+     * Redirect to the latest stable version if requested.
+     *
+     * @param array $request The request array for the request.
+     */
+    protected function maybe_redirect_latest_stable( $request ) {
+        if ( ! $request['is_latest_stable'] ) {
+            return;
+        }
+
+        $file     = $this->get_file( $request );
+        $redirect = 'https://downloads.wordpress.org/plugin/' . basename( $file );
+
+        if ( ! empty( $_SERVER['QUERY_STRING'] ) ) {
+            $redirect .= '?' . $_SERVER['QUERY_STRING'];
+        }
+
+        // CORS, to match the ZIP passthrough.
+        header( 'Access-Control-Allow-Methods: GET, HEAD' );
+        header( 'Access-Control-Allow-Origin: *' );
+
+        // Tell browsers to only cache this for 5 minutes.
+        header( 'Cache-Control: max-age=300' );
+
+        // Redirect to the file they want.
+        header( 'Location: ' . $redirect, 302 );
+        exit;
     }