Changeset 13109 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/api/routes/class-plugin-upload.php

Timestamp:

01/15/2024 05:23:52 AM (2 years ago)

Author:

dd32

Message:

Plugin Directory: Allow plugins to upload additional versions for review.

This is currently limited to new plugins, which is prior to the first human review.

Iterations upon this will open it to plugins in the pending state as well, which is during the human review.

See #7384.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/api/routes/class-plugin-upload.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/api/routes/class-plugin-upload.php

@@ -23 +23 @@
             'methods'             => WP_REST_Server::EDITABLE,
             'callback'            => array( $this, 'upload' ),
-            'permission_callback' => function( $request ) {
-                if (
-                    ! current_user_can( 'plugin_approve' ) &&
-                    get_current_user_id() != get_post_field( 'post_author', $request['ID'] ) 
-                ) {
-                    return false;
-                }
-
-                $post = get_post( $request['ID'] );
-                if ( $post->ID != $request['ID'] || 'plugin' !== $post->post_type ) {
-                    return false;
-                }
-
-                return true;
-            },
+            'permission_callback' => array( $this, 'permission_check' ),
+            'args' => [
+                'post_name' => [
+                    'type'     => 'string',
+                    'required' => false,
+                ],
+            ]
+        ) );
+
+        register_rest_route( 'plugins/v1', '/upload/(?P<ID>[0-9]+)/slug', array(
+            'methods'             => WP_REST_Server::EDITABLE,
+            'callback'            => array( $this, 'slug' ),
+            'permission_callback' => array( $this, 'permission_check' ),
             'args' => [
                 'post_name' => [
                     'type'     => 'string',
                     'required' => true,
-                ]
+                ],
             ]
         ) );
     }
 
+    public function permission_check( $request ) {
+        if (
+            ! current_user_can( 'plugin_approve' ) &&
+            get_current_user_id() != get_post_field( 'post_author', $request['ID'] )
+        ) {
+            return false;
+        }
+
+        $post = get_post( $request['ID'] );
+        if ( $post->ID != $request['ID'] || 'plugin' !== $post->post_type ) {
+            return false;
+        }
+
+        return true;
+    }
+
     public function upload( $request ) {
         $plugin = get_post( $request['ID'] );
+
+        if ( ! empty( $request['post_name'] ) ) {
+            return $this->slug( $request );
+
+        } elseif ( ! empty( $_FILES['zip_file'] ) && current_user_can( 'plugin_approve' ) ) {
+            return ( new Upload_Handler() )->process_upload( $plugin->ID );
+        }
+    }
+
+    /**
+     * Change the slug of a plugin.
+     */
+    public function slug( $request ) {
+        $plugin = get_post( $request['ID'] );
         $slug   = trim( $request['post_name'] ?? '' );
-
         $result = $this->perform_slug_change( $plugin, $slug );
         if ( is_wp_error( $result ) ) {
-            // Warn the reviewer when a plugin author has attempted to use an unavailable slug. 
+            // Warn the reviewer when a plugin author has attempted to use an unavailable slug.
             Tools::audit_log(
                 sprintf(