Changeset 13134

Timestamp:

01/22/2024 02:57:15 AM (3 years ago)

Author:

dd32

Message:

Plugin Directory: Admin: Include a hidden submit button that only submits the form, and doesn't perform actions.

This is needed as the controls include a variety of submit buttons that cause actions to occur, and pressing enter in a form field such as the slug would cause the first submit button to be used.

Fixes #6635.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/metabox/class-controls.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/metabox/class-controls.php

@@ -15 +15 @@
          * Displays the Publish metabox for plugins.
          * The HTML here mostly matches what Core uses.
+         *
+         * NOTE: The input[type="submit"].screen-reader-text is such that the default
+         *       form submit method is a button whose submission causes no action
+         *       (such as approval/rejection/assign). This is used for submit-by-enter.
+         *       See https://meta.trac.wordpress.org/ticket/6635.
          */
         static function display() {
                 ?>
                 <div class="submitbox" id="submitpost">
+                        <input type="submit" name="save_changes" class="screen-reader-text" />
                         <div id="misc-publishing-actions">
                                 <?php