Changeset 13202

Timestamp:

02/12/2024 06:54:46 AM (22 months ago)

Author:

dd32

Message:

Plugin Directory: If a plugin WP_Post does not have a slug set, do not query emails for all plugins.

Every plugin in review should have an associated post_name set, but there appears to be some without.

This prevents errors elsewhere while that's figured out.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory

Files:

• admin/metabox/class-helpscout.php (modified) (1 diff)
• shortcodes/class-upload-handler.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/metabox/class-helpscout.php

@@ -20 +20 @@
         // Trim off the rejected prefix/suffix.
         $slug   = preg_replace( '/(^rejected-|-rejected(-\d)?$)/i', '', $post->post_name );
+
+        // If the slug is not set, we can't query HelpScout.
+        if ( ! $post->post_name || ! $slug ) {
+            echo 'Invalid Slug, cannot query emails.';
+            return;
+        }
+
         $emails = $wpdb->get_results( $wpdb->prepare(
             "SELECT emails.*

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-upload-handler.php

@@ -896 +896 @@
         global $wpdb;
 
-        if ( 'pending' !== $post->post_status ) {
+        if ( 'pending' !== $post->post_status || ! $post->post_name ) {
             return false;
         }