Changeset 13205

Timestamp:

02/12/2024 10:11:54 PM (11 months ago)

Author:

coffee2code

Message:

Photo Directory, Admin: Prevent randomization of the queue if it's explicitly being sorted.

Props mbigul, coffee2code.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/admin.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/admin.php

@@ -1509 +1509 @@
      * Randomizes the list of posts in the queue.
      *
-     * Note: Can be disabled via query string: ?random=0
+     * Note: Can be disabled if explicitly sorting via a post field or via query string: ?random=0
      */
     public static function randomize_the_queue( $query ) {
@@ -1516 +1516 @@
         }
 
-        // Don't randomize if disabled via query parameter.
+        // Bail if disabled via query parameter.
         if ( '0' === $query->get( 'random' ) ) {
+            return;
+        }
+
+        // Bail if already explicitly sorting by a post field.
+        if ( ! empty( $_GET['orderby'] ) && 'random' !== $_GET['orderby'] ) {
             return;
         }