Changeset 13223

Timestamp:

02/20/2024 01:16:24 AM (11 months ago)

Author:

dd32

Message:

Plugin Directory: Cleanup empty terms regularly.

By having less empty terms we get benefits around query performance and less noise to filter.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory

Files:

• class-plugin-directory.php (modified) (1 diff)
• jobs/class-meta-sync.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php

@@ -1382 +1382 @@
 
             wp_safe_redirect( $url, 301 );
-            die();
-        }
-
-        // Existing tag with no plugins.
-        if (
-            is_tax( 'plugin_tags' ) &&
-            ! have_posts() &&
-            // Only redirect if only plugin_tags is queried. Other taxonomies cannot be handled.
-            count( $wp_query->tax_query->queried_terms ) <= 1
-        ) {
-            // [1] => plugins [2] => tags [3] => example-plugin-name [4..] => random().
-            $path = explode( '/', $_SERVER['REQUEST_URI'] );
-
-            wp_safe_redirect( home_url( '/search/' . urlencode( $path[3] ) . '/' ), 301 );
             die();
         }

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-meta-sync.php

@@ -28 +28 @@
         $this->sync_ratings();
         $this->update_tested_up_to();
+        $this->cleanup_empty_terms();
 
         Manager::clear_memory_heavy_variables();
@@ -196 +197 @@
         }
     }
+
+    /**
+     * Remove old plugin tags that are no longer in use.
+     */
+    public function cleanup_empty_terms() {
+        $taxonomies = [
+            'plugin_tags',
+            'plugin_contributors',
+            'plugin_committers',
+            'plugin_support_reps'
+        ];
+        foreach ( $taxonomies as $taxonomy ) {
+            $terms = get_terms( array(
+                'taxonomy'   => $taxonomy,
+                'hide_empty' => false,
+                'count'      => true,
+            ) );
+
+            $terms = array_filter( $terms, function( $term ) {
+                return $term->count === 0;
+            } );
+
+            foreach ( $terms as $term ) {
+                wp_delete_term( $term->term_id, $term->taxonomy );
+            }
+        }
+    }
 }