Changeset 13224 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-meta-sync.php

Timestamp:

02/20/2024 06:11:47 AM (3 years ago)

Author:

dd32

Message:

Plugin Directory: Meta Sync: Cleanup the memory more frequently, optimize the get_terms() calls to avoid OOM issues.

Followup to [13223].

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-meta-sync.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-meta-sync.php

@@ -26 +26 @@
         function sync() {
                 $this->sync_downloads();
+                Manager::clear_memory_heavy_variables();
+
                 $this->sync_ratings();
+                Manager::clear_memory_heavy_variables();
+
                 $this->update_tested_up_to();
+                Manager::clear_memory_heavy_variables();
+
                 $this->cleanup_empty_terms();
-
                 Manager::clear_memory_heavy_variables();
         }
@@ -202 +207 @@
          */
         public function cleanup_empty_terms() {
+                global $wpdb;
+
                 $taxonomies = [
                         'plugin_tags',
@@ -209 +216 @@
                 ];
                 foreach ( $taxonomies as $taxonomy ) {
+                        $term_ids = $wpdb->get_col( $wpdb->prepare(
+                                "SELECT term_id FROM $wpdb->term_taxonomy WHERE taxonomy = %s AND count = 0",
+                                $taxonomy
+                        ) );
+                        if ( ! $term_ids ) {
+                                continue;
+                        }
+
                         $terms = get_terms( array(
                                 'taxonomy'   => $taxonomy,
+                                'include'    => $term_ids,
                                 'hide_empty' => false,
                                 'count'      => true,