Changeset 13292

Timestamp:

03/07/2024 02:46:32 AM (3 years ago)

Author:

dd32

Message:

Plugin Directory: Readme: Parse the first readme header when the readme contains a '=== Plugin Name ===' header.

Follow up to [13162].

See #7428.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/readme/class-parser.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/readme/class-parser.php

@@ -240 +240 @@
                 $this->name = $this->sanitize_text( trim( $line, "#= \t\0\x0B" ) );
 
+                // It's possible to leave the plugin name header off entirely.. 
+                if ( $this->parse_possible_header( $line, true /* only valid headers */ ) ) {
+                        array_unshift( $contents, $line );
+
+                        $this->warnings['invalid_plugin_name_header'] = true;
+                        $this->name                                   = false;
+                }
+
                 // Strip Github style header\n==== underlines.
                 if ( ! empty( $contents ) && '' === trim( $contents[0], '=-' ) ) {
@@ -255 +263 @@
                         if ( strlen( $line ) < 50 && ! $this->parse_possible_header( $line, true /* only valid headers */ ) ) {
                                 $this->name = $this->sanitize_text( trim( $line, "#= \t\0\x0B" ) );
-                        }
-                }
-
-                // It's possible to leave the plugin name header off entirely.
-                if ( $this->parse_possible_header( $this->name, true /* only valid headers */ ) ) {
-                        array_unshift( $contents, $line );
-
-                        $this->warnings['invalid_plugin_name_header'] = true;
-                        $this->name                                   = false;
+                        } else {
+                                // Put it back on the stack to be processed.
+                                array_unshift( $contents, $line );
+                        }
                 }