Changeset 13443 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/readme/class-parser.php

Timestamp:

04/03/2024 07:01:21 AM (6 months ago)

Author:

dd32

Message:

Plugin Directory: Store error codes (rather than english error messages) that occur during a plugin import, to allow the errors to be generated with the appropriate translations.

This expands some errors to better highlight what is invalid as well.

See #6108.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/readme/class-parser.php (modified) (4 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/readme/class-parser.php

@@ -308 +308 @@
             $this->tags = array_map( 'trim', $this->tags );
             $this->tags = array_filter( $this->tags );
+
             if ( array_intersect( $this->tags, $this->ignore_tags ) ) {
                 $this->tags = array_diff( $this->tags, $this->ignore_tags );
@@ -313 +314 @@
             }
 
-            // Check if the tags are low-quality (ie. little used)
-            if ( $this->tags && taxonomy_exists( 'plugin_tags' ) ) {
-                $tags = get_terms( array(
-                    'taxonomy' => 'plugin_tags',
-                    'name'     => $this->tags,
-                ) );
-
-                $low_usage_tags = array_filter(
-                    $tags,
-                    function( $term ) {
-                        return $term->count < 5;
-                    }
-                );
-
-                $this->warnings['low_usage_tags'] = wp_list_pluck( $low_usage_tags, 'name' );
-            }
-
             if ( count( $this->tags ) > 5 ) {
+                $this->warnings['too_many_tags'] = array_slice( $this->tags, 4 );
                 $this->tags = array_slice( $this->tags, 0, 5 );
-                $this->warnings['too_many_tags'] = true;
             }
         }
@@ -715 +699 @@
             // In the event that something invalid is used, we'll ignore it (Example: 'Joe Bloggs (Australian Translation)')
             if ( ! $user ) {
+                $this->warnings['contributor_ignored'] ??= [];
+                $this->warnings['contributor_ignored'][] = $name;
                 unset( $users[ $i ] );
-                $this->warnings['contributor_ignored'] = true;
                 continue;
             }
@@ -723 +708 @@
             $users[ $i ] = $user->user_nicename;
         }
-
         return $users;
     }