Changeset 13485

Timestamp:

04/10/2024 04:04:23 AM (13 months ago)

Author:

adamwood

Message:

wporg-support-2024: Fix headings hierarchy

Updates the sidebar headings to h2 and h3 to correct the headings hierarchy

See https://meta.trac.wordpress.org/ticket/4117

Location:

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-support-2024

Files:

• functions.php (modified) (1 diff)
• sass/site/_site.scss (modified) (1 diff)
• sidebar.php (modified) (4 diffs)
• style-rtl.css (modified) (1 diff)
• style.css (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-support-2024/functions.php

@@ -494 +494 @@
         }
 
-        $output .= sprintf( '<a class="bbp-view-title wp-block-wporg-link-wrapper is-layout-flow wp-block-wporg-link-wrapper-is-layout-flow" href="%s"><h5 class="wp-block-heading has-inter-font-family has-small-font-size" style="font-weight:700;margin-bottom:0">%s</h5></a>',
+        $output .= sprintf( '<a class="bbp-view-title wp-block-wporg-link-wrapper is-layout-flow wp-block-wporg-link-wrapper-is-layout-flow" href="%s"><h3 class="wp-block-heading has-inter-font-family has-small-font-size" style="font-weight:700;margin-bottom:0">%s</h3></a>',
             esc_url( bbp_get_view_url( $view ) ),
             bbp_get_view_title( $view )

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-support-2024/sass/site/_site.scss

@@ -330 +330 @@
     }
 
-    h4 {
+    h2 {
         font-weight: 400;
         font-size: var(--wp--preset--font-size--normal);

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-support-2024/sidebar.php

@@ -43 +43 @@
             <div>
                 <?php bbp_topic_tag_list( 0, array(
-                    'before' => '<h4>' . __( 'Tags', 'wporg-forums' ) . '</h4><ul class="topic-tags"><li class="tag">',
+                    'before' => '<h2>' . __( 'Tags', 'wporg-forums' ) . '</h2><ul class="topic-tags"><li class="tag">',
                     'after'  => '</li></ul>',
                     'sep'    => '</li><li class="tag">',
@@ -60 +60 @@
                     <?php bbp_topic_admin_links( array (
                         'id'     => bbp_get_topic_id(),
-                        'before' => '<h4>' . __( 'Admin', 'wporg-forums' ) . '</h4><ul class="topic-admin-links"><li>',
+                        'before' => '<h2>' . __( 'Admin', 'wporg-forums' ) . '</h2><ul class="topic-admin-links"><li>',
                         'after'  => '</li></ul>',
                         'sep'    => '</li><li>',
@@ -86 +86 @@
 
             <div>
-                <h4><?php _e( 'Topics', 'wporg-forums' ); ?></h4>
+                <h2><?php _e( 'Topics', 'wporg-forums' ); ?></h2>
 
                 <?php echo do_blocks(
@@ -103 +103 @@
 
             <div>
-                <h4><?php _e( 'Feeds', 'wporg-forums' ); ?></h4>
+                <h2><?php _e( 'Feeds', 'wporg-forums' ); ?></h2>
                 <ul class="forum-feeds">
                     <li><a class="feed" href="<?php bbp_forums_url(); ?>feed/"><?php _e( 'RSS Recent Posts', 'wporg-forums' ); ?></a></li>

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-support-2024/style-rtl.css

@@ -2414 +2414 @@
     text-decoration: underline;
 }
-.sidebar h4, .sidebar .bbp-view .review-ratings .col-5 > div:first-child, .bbp-view .review-ratings .sidebar .col-5 > div:first-child {
+.sidebar h2 {
     font-weight: 400;
     font-size: var(--wp--preset--font-size--normal);

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-support-2024/style.css

@@ -2414 +2414 @@
     text-decoration: underline;
 }
-.sidebar h4, .sidebar .bbp-view .review-ratings .col-5 > div:first-child, .bbp-view .review-ratings .sidebar .col-5 > div:first-child {
+.sidebar h2 {
     font-weight: 400;
     font-size: var(--wp--preset--font-size--normal);