Changeset 13505 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/metabox/class-review-tools.php

Timestamp:

04/12/2024 03:37:30 AM (11 months ago)

Author:

dd32

Message:

Plugin Directory: Avoid PHP Warnings when the uploaded file doesn't exist.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/metabox/class-review-tools.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/metabox/class-review-tools.php

@@ -115 +115 @@
         $zip_files = array();
         foreach ( get_attached_media( 'application/zip', $post ) as $zip_file ) {
-            $zip_files[ $zip_file->post_date ] = array( wp_get_attachment_url( $zip_file->ID ), $zip_file );
+            $zip_files[ $zip_file->post_date ] = array(
+                wp_get_attachment_url( $zip_file->ID ),
+                $zip_file,
+                get_attached_file( $zip_file->ID )
+            );
         }
 
@@ -126 +130 @@
             echo '<ul class="plugin-zip-files">';
             foreach ( $zip_files as $zip_date => $zip ) {
-                list( $zip_url, $zip_file ) = $zip;
-                $zip_size                   = size_format( filesize( get_attached_file( $zip_file->ID ) ), 1 );
-                $zip_preview                = Template::preview_link_zip( $slug, $zip_file->ID );
-                $zip_pcp                    = Template::preview_link_zip( $slug, $zip_file->ID, 'pcp' );
+                list( $zip_url, $zip_file, $file_on_disk ) = $zip;
+
+                if ( ! file_exists( $file_on_disk ) ) {
+                    continue;
+                }
+
+                $zip_size    = size_format( filesize( $file_on_disk ), 1 );
+                $zip_preview = Template::preview_link_zip( $slug, $zip_file->ID );
+                $zip_pcp     = Template::preview_link_zip( $slug, $zip_file->ID, 'pcp' );
 
                 printf(