Changeset 13509

Timestamp:

04/12/2024 04:18:08 AM (2 years ago)

Author:

dd32

Message:

Support Forums: Ratings: Only adjust the Topic queries with the ratings join.

This previously adjusted all WP_Query instances, which caused queries for WordPress core post types to fail on filtered review views.

See [13489].

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-ratings-compat.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-ratings-compat.php

@@ -45 +45 @@
                         }
                         $this->filter = $filter;
-                        add_filter( 'posts_clauses', array( $this, 'add_filter_to_posts_clauses' ) );
+                        add_filter( 'posts_clauses', array( $this, 'add_filter_to_posts_clauses' ), 10, 2 );
                         add_action( 'pre_get_posts', array( $this, 'no_found_rows' ) );
                         add_filter( 'bbp_topic_pagination', array( $this, 'add_filter_topic_pagination' ) );
 
                         // <meta robots="noindex,follow"> for filtered views.
-                        add_filter( 'wp_head', 'wp_no_robots' );
+                        add_filter( 'wp_robots', 'wp_robots_no_robots' );
                 }
 
@@ -94 +94 @@
          * Allow ratings view to be filtered by star rating.
          */
-        public function add_filter_to_posts_clauses( $clauses ) {
+        public function add_filter_to_posts_clauses( $clauses, $query ) {
                 global $wpdb;
 
-                if ( false !== strpos( $clauses['where'], ".post_type = 'wp_navigation' " ) ) {
+                // Only adjust topic queries.
+                if ( ! in_array( bbp_get_topic_post_type(), (array) $query->get( 'post_type' ) ) ) {
                         return $clauses;
                 }