Changeset 13609

Timestamp:

04/29/2024 07:02:02 AM (2 years ago)

Author:

dd32

Message:

Plugin Directory: Fix an issue where some ZIP uploads would not properly notify reviewers in Helpscout.

Helpscout rejects API requests which specify a firstName or lastName that is 0 or 41+ characters long.

See #7598, [13607].

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-upload-handler.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-upload-handler.php

@@ -768 +768 @@
          * @return bool True if the email was updated, false otherwise.
          */
-        public function update_review_email( $post, $attachment ) {
+        public static function update_review_email( $post, $attachment ) {
                 $review_email = self::find_review_email( $post );
                 if ( ! $review_email ) {
@@ -789 +789 @@
                 $name = wp_get_current_user()->display_name ?: wp_get_current_user()->user_login;
                 $payload = [
-                        'customer' => [
-                                'firstName' => explode( ' ', $name, 2 )[0],
-                                'lastName'  => trim( explode( ' ', "{$name} ", 2 )[1] ),
+                        'customer' => array_filter( [
+                                'firstName' => substr( explode( ' ', $name, 2 )[0], 0, 39 ),
+                                'lastName'  => trim( substr( explode( ' ', "{$name} ", 2 )[1], 0, 39 ) ),
                                 'email'     => wp_get_current_user()->user_email,
-                        ],
+                        ] ),
                         'text'   => $text,
                         'status' => 'active',