WordPress.org
Get WordPress

Making WordPress.org

Changeset 13626


Ignore:
Timestamp:
04/30/2024 07:07:26 AM (6 months ago)
Author:
dd32
Message:

Plugin Directory: Add an empty alt tag to plugin icons, move the plugin icon into the title link, and mark the remaining dashicon as aria-hidden.

Prpos sabernhardt.
Merges ​https://github.com/WordPress/wordpress.org/pull/136.
See #4730.

Location:
sites/trunk/wordpress.org/public_html/wp-content
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-template.php

    r13620 r13626  
    402402
    403403                if ( $icon_2x && $icon_2x !== $icon ) {
    404                     return "<img class='plugin-icon' srcset='{$icon}, {$icon_2x} 2x' src='{$icon_2x}'>";
     404                    return "<img class='plugin-icon' srcset='{$icon}, {$icon_2x} 2x' src='{$icon_2x}' alt=''>";
    405405                } else {
    406                     return "<img class='plugin-icon' src='{$icon}'>";
     406                    return "<img class='plugin-icon' src='{$icon}' alt=''>";
    407407                }
    408408                break;

  • sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins-2024/embed-plugin.php

    r13277 r13626  
    3535            vertical-align: initial;
    3636        }
    37         .wp-embed-featured-image {
     37        .plugin-icon {
    3838            float: left;
    3939            margin-right: 20px;
    4040        }
    41         html[dir="rtl"] .wp-embed-featured-image {
     41        html[dir="rtl"] .plugin-icon {
    4242            float: right;
    4343            margin-left: 20px;
    4444            margin-right: auto;
    4545        }
    46         .wp-embed-featured-image .plugin-icon {
     46        .plugin-icon {
    4747            background-size: 100%;
    4848            height: 64px;
    4949            width: 64px;
     50            margin-bottom: 20px;
    5051        }
    5152        p.wp-embed-heading {
    … …  
    114115<body <?php body_class(); ?>>
    115116    <div <?php post_class( 'wp-embed' ); ?>>
    116         <div class="wp-embed-featured-image rectangular">
    117             <a href="<?php the_permalink(); ?>" target="_top">
    118                 <?php echo Template::get_plugin_icon( $post, 'html' ); /* phpcs:ignore WordPress.XSS.EscapeOutput.OutputNotEscaped */ ?>
    119             </a>
    120         </div>
    121117
    122118        <p class="wp-embed-heading">
    123119            <a href="<?php the_permalink(); ?>" target="_top">
     120                <?php echo Template::get_plugin_icon( $post, 'html' ); /* phpcs:ignore WordPress.XSS.EscapeOutput.OutputNotEscaped */ ?>
    124121                <?php the_title(); ?>
    125122            </a>
    … …  
    155152                ?>
    156153                <span class="tested-with">
    157                     <i class="dashicons dashicons-wordpress-alt"></i>
     154                    <i class="dashicons dashicons-wordpress-alt" aria-hidden="true"></i>
    158155                    <?php
    159156                    /* translators: WordPress version. */
Note: See TracChangeset for help on using the changeset viewer.