Changeset 13703

Timestamp:

05/14/2024 11:01:05 PM (21 months ago)

Author:

ryelle

Message:

Theme Directory: Ingore paged param when checking whether to set a default browse.

The new block theme uses default pagination, e.g. /themes/page/2/, for the homepage. On the homepage, browse=popular is set correctly, but following pages did not set browse, causing paged requests to serve latest results instead. Ignoring paged in the default check ensures the correct browse type is used.

See ​https://github.com/WordPress/wporg-theme-directory/issues/68#issuecomment-2111273950.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/query-modifications.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/query-modifications.php

@@ -19 +19 @@
     }
 
-    // Default to the ~featured~ popular view
-    if ( empty( $query->query ) ) {
+    // Default to the popular view if this is a default query (ignore `paged`,
+    // so that `/themes/page/2/` correctly loads popular results).
+    $query_vars = array_diff( array_keys( $query->query ), [ 'paged' ] );
+    if ( empty( $query_vars ) ) {
         $query->query_vars['browse'] = 'popular';
     }